2020-02-12 16:22:12

by Eric Whitney

Subject: [PATCH] ext4: delete declaration for ext4_split_extent()

There are no forward references for ext4_split_extent() in extents.c,
so delete its unnecessary declaration.

Signed-off-by: Eric Whitney <[email protected]>
---
fs/ext4/extents.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 89aa9c7ae293..a5338a8da2ab 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -83,13 +83,6 @@ static void ext4_extent_block_csum_set(struct inode *inode,
et->et_checksum = ext4_extent_block_csum(inode, eh);
}

-static int ext4_split_extent(handle_t *handle,
- struct inode *inode,
- struct ext4_ext_path **ppath,
- struct ext4_map_blocks *map,
- int split_flag,
- int flags);
-
static int ext4_split_extent_at(handle_t *handle,
struct inode *inode,
struct ext4_ext_path **ppath,
--
2.11.0

2020-02-12 17:03:49

by Darrick J. Wong

Subject: Re: [PATCH] ext4: delete declaration for ext4_split_extent()

On Wed, Feb 12, 2020 at 11:21:41AM -0500, Eric Whitney wrote:
> There are no forward references for ext4_split_extent() in extents.c,
> so delete its unnecessary declaration.
>
> Signed-off-by: Eric Whitney <[email protected]>

Looks good to me,
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/ext4/extents.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 89aa9c7ae293..a5338a8da2ab 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -83,13 +83,6 @@ static void ext4_extent_block_csum_set(struct inode *inode,
> et->et_checksum = ext4_extent_block_csum(inode, eh);
> }
>
> -static int ext4_split_extent(handle_t *handle,
> - struct inode *inode,
> - struct ext4_ext_path **ppath,
> - struct ext4_map_blocks *map,
> - int split_flag,
> - int flags);
> -
> static int ext4_split_extent_at(handle_t *handle,
> struct inode *inode,
> struct ext4_ext_path **ppath,
> --
> 2.11.0
>

2020-03-05 21:28:52

by Theodore Ts'o

Subject: Re: [PATCH] ext4: delete declaration for ext4_split_extent()

On Wed, Feb 12, 2020 at 09:02:36AM -0800, Darrick J. Wong wrote:
> On Wed, Feb 12, 2020 at 11:21:41AM -0500, Eric Whitney wrote:
> > There are no forward references for ext4_split_extent() in extents.c,
> > so delete its unnecessary declaration.
> >
> > Signed-off-by: Eric Whitney <[email protected]>
>
> Looks good to me,
> Reviewed-by: Darrick J. Wong <[email protected]>

Applied, thanks.

- Ted