2020-05-05 10:31:09

by Anders Roxell

Subject: [PATCH v2 3/6] lib: Kconfig.debug: default KUNIT_* fragments to KUNIT_RUN_ALL

This makes it easier to enable all KUnit fragments.

Adding 'if !KUNIT_RUN_ALL' so individual test can be turned of if
someone wants that even though KUNIT_RUN_ALL is enabled.

Signed-off-by: Anders Roxell <[email protected]>
---
lib/Kconfig.debug | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 21d9c5f6e7ec..d1a94ff56a87 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2064,8 +2064,9 @@ config TEST_SYSCTL
If unsure, say N.

config SYSCTL_KUNIT_TEST
- tristate "KUnit test for sysctl"
+ tristate "KUnit test for sysctl" if !KUNIT_RUN_ALL
depends on KUNIT
+ default KUNIT_RUN_ALL
help
This builds the proc sysctl unit test, which runs on boot.
Tests the API contract and implementation correctness of sysctl.
@@ -2075,8 +2076,9 @@ config SYSCTL_KUNIT_TEST
If unsure, say N.

config LIST_KUNIT_TEST
- tristate "KUnit Test for Kernel Linked-list structures"
+ tristate "KUnit Test for Kernel Linked-list structures" if !KUNIT_RUN_ALL
depends on KUNIT
+ default KUNIT_RUN_ALL
help
This builds the linked list KUnit test suite.
It tests that the API and basic functionality of the list_head type
--
2.20.1

2020-05-07 03:26:29

by David Gow

Subject: Re: [PATCH v2 3/6] lib: Kconfig.debug: default KUNIT_* fragments to KUNIT_RUN_ALL

On Tue, May 5, 2020 at 6:27 PM Anders Roxell <[email protected]> wrote:
>
> This makes it easier to enable all KUnit fragments.
>
> Adding 'if !KUNIT_RUN_ALL' so individual test can be turned of if
> someone wants that even though KUNIT_RUN_ALL is enabled.
>
> Signed-off-by: Anders Roxell <[email protected]>

Reviewed-by: David Gow <[email protected]>

Thanks!
-- David


> ---
> lib/Kconfig.debug | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 21d9c5f6e7ec..d1a94ff56a87 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2064,8 +2064,9 @@ config TEST_SYSCTL
> If unsure, say N.
>
> config SYSCTL_KUNIT_TEST
> - tristate "KUnit test for sysctl"
> + tristate "KUnit test for sysctl" if !KUNIT_RUN_ALL
> depends on KUNIT
> + default KUNIT_RUN_ALL
> help
> This builds the proc sysctl unit test, which runs on boot.
> Tests the API contract and implementation correctness of sysctl.
> @@ -2075,8 +2076,9 @@ config SYSCTL_KUNIT_TEST
> If unsure, say N.
>
> config LIST_KUNIT_TEST
> - tristate "KUnit Test for Kernel Linked-list structures"
> + tristate "KUnit Test for Kernel Linked-list structures" if !KUNIT_RUN_ALL
> depends on KUNIT
> + default KUNIT_RUN_ALL
> help
> This builds the linked list KUnit test suite.
> It tests that the API and basic functionality of the list_head type
> --
> 2.20.1
>