2020-05-05 10:28:36

by Anders Roxell

Subject: [PATCH v2 5/6] fs: ext4: default KUNIT_* fragments to KUNIT_RUN_ALL

This makes it easier to enable all KUnit fragments.

Adding 'if !KUNIT_RUN_ALL' so individual test can be turned of if
someone wants that even though KUNIT_RUN_ALL is enabled.

Signed-off-by: Anders Roxell <[email protected]>
---
fs/ext4/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
index 2a592e38cdfe..76785143259d 100644
--- a/fs/ext4/Kconfig
+++ b/fs/ext4/Kconfig
@@ -103,9 +103,10 @@ config EXT4_DEBUG
echo 1 > /sys/module/ext4/parameters/mballoc_debug

config EXT4_KUNIT_TESTS
- tristate "KUnit tests for ext4"
+ tristate "KUnit tests for ext4" if !KUNIT_RUN_ALL
select EXT4_FS
depends on KUNIT
+ default KUNIT_RUN_ALL
help
This builds the ext4 KUnit tests.

--
2.20.1

2020-05-07 03:27:46

by David Gow

Subject: Re: [PATCH v2 5/6] fs: ext4: default KUNIT_* fragments to KUNIT_RUN_ALL

On Tue, May 5, 2020 at 6:27 PM Anders Roxell <[email protected]> wrote:
>
> This makes it easier to enable all KUnit fragments.
>
> Adding 'if !KUNIT_RUN_ALL' so individual test can be turned of if
> someone wants that even though KUNIT_RUN_ALL is enabled.

As with the others, "test"->"tests", and "of"->"off".

>
> Signed-off-by: Anders Roxell <[email protected]>

Reviewed-by: David Gow <[email protected]>

> ---
> fs/ext4/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index 2a592e38cdfe..76785143259d 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -103,9 +103,10 @@ config EXT4_DEBUG
> echo 1 > /sys/module/ext4/parameters/mballoc_debug
>
> config EXT4_KUNIT_TESTS
> - tristate "KUnit tests for ext4"
> + tristate "KUnit tests for ext4" if !KUNIT_RUN_ALL
> select EXT4_FS
> depends on KUNIT
> + default KUNIT_RUN_ALL
> help
> This builds the ext4 KUnit tests.
>
> --
> 2.20.1
>