2020-06-11 03:21:44

by Keyur Patel

[permalink] [raw]
Subject: [PATCH] ext4: fix spelling mistakes in extents.c

Fix spelling issues over the comments in the code.

requsted ==> requested
deterimined ==> determined
insde ==> inside
neet ==> need
somthing ==> something

Signed-off-by: Keyur Patel <[email protected]>
---
fs/ext4/extents.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 7d088ff1e902..8028e1aae8de 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1915,7 +1915,7 @@ static unsigned int ext4_ext_check_overlap(struct ext4_sb_info *sbi,

/*
* ext4_ext_insert_extent:
- * tries to merge requsted extent into the existing extent or
+ * tries to merge requested extent into the existing extent or
* inserts requested extent as new one into the tree,
* creating new leaf in the no-space case.
*/
@@ -3125,7 +3125,7 @@ static int ext4_ext_zeroout(struct inode *inode, struct ext4_extent *ex)
*
*
* Splits extent [a, b] into two extents [a, @split) and [@split, b], states
- * of which are deterimined by split_flag.
+ * of which are determined by split_flag.
*
* There are two cases:
* a> the extent are splitted into two extent.
@@ -3650,7 +3650,7 @@ static int ext4_split_convert_extents(handle_t *handle,
eof_block = map->m_lblk + map->m_len;
/*
* It is safe to convert extent to initialized via explicit
- * zeroout only if extent is fully insde i_size or new_size.
+ * zeroout only if extent is fully inside i_size or new_size.
*/
depth = ext_depth(inode);
ex = path[depth].p_ext;
@@ -4495,7 +4495,7 @@ static long ext4_zero_range(struct file *file, loff_t offset,
}

/*
- * Round up offset. This is not fallocate, we neet to zero out
+ * Round up offset. This is not fallocate, we need to zero out
* blocks, so convert interior block aligned part of the range to
* unwritten and possibly manually zero out unaligned parts of the
* range.
@@ -5579,7 +5579,7 @@ ext4_swap_extents(handle_t *handle, struct inode *inode1,
}
ex1 = path1[path1->p_depth].p_ext;
ex2 = path2[path2->p_depth].p_ext;
- /* Do we have somthing to swap ? */
+ /* Do we have something to swap ? */
if (unlikely(!ex2 || !ex1))
goto finish;

--
2.26.2


2020-07-08 13:45:40

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH] ext4: fix spelling mistakes in extents.c

On Wed 10-06-20 23:19:46, Keyur Patel wrote:
> Fix spelling issues over the comments in the code.
>
> requsted ==> requested
> deterimined ==> determined
> insde ==> inside
> neet ==> need
> somthing ==> something
>
> Signed-off-by: Keyur Patel <[email protected]>

Thanks. The fixes look good. You can add:

Reviewed-by: Jan Kara <[email protected]>

Ted, I think this patch has fallen through the cracks...

Honza
> ---
> fs/ext4/extents.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 7d088ff1e902..8028e1aae8de 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1915,7 +1915,7 @@ static unsigned int ext4_ext_check_overlap(struct ext4_sb_info *sbi,
>
> /*
> * ext4_ext_insert_extent:
> - * tries to merge requsted extent into the existing extent or
> + * tries to merge requested extent into the existing extent or
> * inserts requested extent as new one into the tree,
> * creating new leaf in the no-space case.
> */
> @@ -3125,7 +3125,7 @@ static int ext4_ext_zeroout(struct inode *inode, struct ext4_extent *ex)
> *
> *
> * Splits extent [a, b] into two extents [a, @split) and [@split, b], states
> - * of which are deterimined by split_flag.
> + * of which are determined by split_flag.
> *
> * There are two cases:
> * a> the extent are splitted into two extent.
> @@ -3650,7 +3650,7 @@ static int ext4_split_convert_extents(handle_t *handle,
> eof_block = map->m_lblk + map->m_len;
> /*
> * It is safe to convert extent to initialized via explicit
> - * zeroout only if extent is fully insde i_size or new_size.
> + * zeroout only if extent is fully inside i_size or new_size.
> */
> depth = ext_depth(inode);
> ex = path[depth].p_ext;
> @@ -4495,7 +4495,7 @@ static long ext4_zero_range(struct file *file, loff_t offset,
> }
>
> /*
> - * Round up offset. This is not fallocate, we neet to zero out
> + * Round up offset. This is not fallocate, we need to zero out
> * blocks, so convert interior block aligned part of the range to
> * unwritten and possibly manually zero out unaligned parts of the
> * range.
> @@ -5579,7 +5579,7 @@ ext4_swap_extents(handle_t *handle, struct inode *inode1,
> }
> ex1 = path1[path1->p_depth].p_ext;
> ex2 = path2[path2->p_depth].p_ext;
> - /* Do we have somthing to swap ? */
> + /* Do we have something to swap ? */
> if (unlikely(!ex2 || !ex1))
> goto finish;
>
> --
> 2.26.2
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2020-07-29 20:13:26

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] ext4: fix spelling mistakes in extents.c

On Wed, Jun 10, 2020 at 11:19:46PM -0400, Keyur Patel wrote:
> Fix spelling issues over the comments in the code.
>
> requsted ==> requested
> deterimined ==> determined
> insde ==> inside
> neet ==> need
> somthing ==> something
>
> Signed-off-by: Keyur Patel <[email protected]>

Applied, thanks.

- Ted