2020-07-24 01:49:25

by Shijie Luo

Subject: [PATCH] ext4:remove some redundant function declarations

ext4 update feature functions do not exist now, remove these useless
function declarations.

Signed-off-by: Shijie Luo <[email protected]>
---
fs/ext4/ext4.h | 6 ------
1 file changed, 6 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 42f5060f3cdf..196b52c75422 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2924,12 +2924,6 @@ do { \

#endif

-extern int ext4_update_compat_feature(handle_t *handle, struct super_block *sb,
- __u32 compat);
-extern int ext4_update_rocompat_feature(handle_t *handle,
- struct super_block *sb, __u32 rocompat);
-extern int ext4_update_incompat_feature(handle_t *handle,
- struct super_block *sb, __u32 incompat);
extern ext4_fsblk_t ext4_block_bitmap(struct super_block *sb,
struct ext4_group_desc *bg);
extern ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb,
--
2.19.1

2020-07-24 03:01:44

by Ritesh Harjani

Subject: Re: [PATCH] ext4:remove some redundant function declarations

On 7/24/20 7:17 AM, Shijie Luo wrote:
> ext4 update feature functions do not exist now, remove these useless
> function declarations.
>
> Signed-off-by: Shijie Luo <[email protected]>

LGTM, feel free to add:
Reviewed-by: Ritesh Harjani <[email protected]>

> ---
> fs/ext4/ext4.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 42f5060f3cdf..196b52c75422 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2924,12 +2924,6 @@ do { \
>
> #endif
>
> -extern int ext4_update_compat_feature(handle_t *handle, struct super_block *sb,
> - __u32 compat);
> -extern int ext4_update_rocompat_feature(handle_t *handle,
> - struct super_block *sb, __u32 rocompat);
> -extern int ext4_update_incompat_feature(handle_t *handle,
> - struct super_block *sb, __u32 incompat);
> extern ext4_fsblk_t ext4_block_bitmap(struct super_block *sb,
> struct ext4_group_desc *bg);
> extern ext4_fsblk_t ext4_inode_bitmap(struct super_block *sb,
>