2020-08-10 08:08:19

by Kyoungho Koo

Subject: [PATCH] ext4: remove unused parameter of ext4_generic_delete_entry function

The ext4_generic_delete_entry function defines the handle_t type
variable, handle, as a parameter, but it is not used.

Signed-off-by: Kyoungho Koo <[email protected]>
---
fs/ext4/ext4.h | 3 +--
fs/ext4/inline.c | 2 +-
fs/ext4/namei.c | 6 ++----
3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 5148cbb0b4b3..feda8b65924b 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2764,8 +2764,7 @@ extern int ext4_search_dir(struct buffer_head *bh,
struct ext4_filename *fname,
unsigned int offset,
struct ext4_dir_entry_2 **res_dir);
-extern int ext4_generic_delete_entry(handle_t *handle,
- struct inode *dir,
+extern int ext4_generic_delete_entry(struct inode *dir,
struct ext4_dir_entry_2 *de_del,
struct buffer_head *bh,
void *entry_buf,
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index c3a1ad2db122..13054653a06a 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -1706,7 +1706,7 @@ int ext4_delete_inline_entry(handle_t *handle,
if (err)
goto out;

- err = ext4_generic_delete_entry(handle, dir, de_del, bh,
+ err = ext4_generic_delete_entry(dir, de_del, bh,
inline_start, inline_size, 0);
if (err)
goto out;
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 56738b538ddf..f5e60c622ce2 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2455,8 +2455,7 @@ static int ext4_dx_add_entry(handle_t *handle, struct ext4_filename *fname,
* ext4_generic_delete_entry deletes a directory entry by merging it
* with the previous entry
*/
-int ext4_generic_delete_entry(handle_t *handle,
- struct inode *dir,
+int ext4_generic_delete_entry(struct inode *dir,
struct ext4_dir_entry_2 *de_del,
struct buffer_head *bh,
void *entry_buf,
@@ -2517,8 +2516,7 @@ static int ext4_delete_entry(handle_t *handle,
if (unlikely(err))
goto out;

- err = ext4_generic_delete_entry(handle, dir, de_del,
- bh, bh->b_data,
+ err = ext4_generic_delete_entry(dir, de_del, bh, bh->b_data,
dir->i_sb->s_blocksize, csum_size);
if (err)
goto out;
--
2.17.1

2020-08-10 08:39:43

by Ritesh Harjani

Subject: Re: [PATCH] ext4: remove unused parameter of ext4_generic_delete_entry function

On 8/10/20 1:37 PM, Kyoungho Koo wrote:
> The ext4_generic_delete_entry function defines the handle_t type
> variable, handle, as a parameter, but it is not used.
>
> Signed-off-by: Kyoungho Koo <[email protected]>

LGTM, feel free to add:
Reviewed-by: Ritesh Harjani <[email protected]>

2020-08-18 18:27:39

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove unused parameter of ext4_generic_delete_entry function

On Mon, Aug 10, 2020 at 05:07:05PM +0900, Kyoungho Koo wrote:
> The ext4_generic_delete_entry function defines the handle_t type
> variable, handle, as a parameter, but it is not used.
>
> Signed-off-by: Kyoungho Koo <[email protected]>

Applied, thanks.

- Ted