2020-08-07 14:09:56

by brookxu.cn

[permalink] [raw]
Subject: [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment

Fix typos in ext4_mb_regular_allocator() comment

Signed-off-by: Chunguang Xu <[email protected]>
---
fs/ext4/mballoc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 4f21f34..0edec26 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2237,8 +2237,8 @@ static int ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
goto out;

/*
- * ac->ac2_order is set only if the fe_len is a power of 2
- * if ac2_order is set we also set criteria to 0 so that we
+ * ac->ac_2order is set only if the fe_len is a power of 2
+ * if ac->ac_2order is set we also set criteria to 0 so that we
* try exact allocation using buddy.
*/
i = fls(ac->ac_g_ex.fe_len);
--
1.8.3.1


2020-08-13 08:21:17

by Andreas Dilger

[permalink] [raw]
Subject: Re: [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment


> On Aug 7, 2020, at 8:01 AM, brookxu <[email protected]> wrote:
>
> Fix typos in ext4_mb_regular_allocator() comment
>
> Signed-off-by: Chunguang Xu <[email protected]>

Reviewed-by: Andreas Dilger <[email protected]>

> ---
> fs/ext4/mballoc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 4f21f34..0edec26 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2237,8 +2237,8 @@ static int ext4_mb_good_group_nolock(struct ext4_allocation_context *ac,
> goto out;
>
> /*
> - * ac->ac2_order is set only if the fe_len is a power of 2
> - * if ac2_order is set we also set criteria to 0 so that we
> + * ac->ac_2order is set only if the fe_len is a power of 2
> + * if ac->ac_2order is set we also set criteria to 0 so that we
> * try exact allocation using buddy.
> */
> i = fls(ac->ac_g_ex.fe_len);
> --
> 1.8.3.1


Cheers, Andreas





Attachments:
signature.asc (890.00 B)
Message signed with OpenPGP

2020-08-13 13:55:56

by Ritesh Harjani

[permalink] [raw]
Subject: Re: [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment



On 8/7/20 7:31 PM, brookxu wrote:
> Fix typos in ext4_mb_regular_allocator() comment
>
> Signed-off-by: Chunguang Xu <[email protected]>

Looks good to me.
Reviewed-by: Ritesh Harjani <[email protected]>

2020-08-18 18:16:17

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] ext4: fix typos in ext4_mb_regular_allocator() comment

On Fri, Aug 07, 2020 at 10:01:23PM +0800, brookxu wrote:
> Fix typos in ext4_mb_regular_allocator() comment
>
> Signed-off-by: Chunguang Xu <[email protected]>

Thanks, applied.

- Ted