2022-12-08 02:13:28

by Ye Bin

Subject: [PATCH v3 2/4] ext4: allocate extended attribute value in vmalloc area

From: Ye Bin <[email protected]>

Now, extended attribute value maximum length is 64K. The memory requested
here does not need continuous physical addresses, so it is appropriate to
use kvmalloc to request memory. At the same time, it can also cope with
the situation that the extended attribute will become longer in the future.

Signed-off-by: Ye Bin <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
---
fs/ext4/xattr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 718ef3987f94..23cfefc6d262 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -2556,7 +2556,7 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode,

is = kzalloc(sizeof(struct ext4_xattr_ibody_find), GFP_NOFS);
bs = kzalloc(sizeof(struct ext4_xattr_block_find), GFP_NOFS);
- buffer = kmalloc(value_size, GFP_NOFS);
+ buffer = kvmalloc(value_size, GFP_NOFS);
b_entry_name = kmalloc(entry->e_name_len + 1, GFP_NOFS);
if (!is || !bs || !buffer || !b_entry_name) {
error = -ENOMEM;
@@ -2608,7 +2608,7 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode,
error = 0;
out:
kfree(b_entry_name);
- kfree(buffer);
+ kvfree(buffer);
if (is)
brelse(is->iloc.bh);
if (bs)
--
2.31.1

2022-12-09 05:39:11

by Theodore Ts'o

Subject: Re: [PATCH v3 2/4] ext4: allocate extended attribute value in vmalloc area

On Thu, Dec 08, 2022 at 10:32:31AM +0800, Ye Bin wrote:
> From: Ye Bin <[email protected]>
>
> Now, extended attribute value maximum length is 64K. The memory requested
> here does not need continuous physical addresses, so it is appropriate to
> use kvmalloc to request memory. At the same time, it can also cope with
> the situation that the extended attribute will become longer in the future.
>
> Signed-off-by: Ye Bin <[email protected]>
> Reviewed-by: Jan Kara <[email protected]>

Applied, thanks.

- Ted