2022-12-30 14:28:06

by Tanmay Bhushan

Subject: [PATCH] ext4: remove dead code in updating backup sb

ext4_update_backup_sb checks for err having some value
after unlocking buffer. But err has not been updated
till that point in any code which will lead execution
of the code in question.

Signed-off-by: Tanmay Bhushan <[email protected]>
---
fs/ext4/ioctl.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 8067ccda34e4..2e8c34036313 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -155,9 +155,6 @@ static int ext4_update_backup_sb(struct super_block *sb,
set_buffer_uptodate(bh);
unlock_buffer(bh);

- if (err)
- goto out_bh;
-
if (handle) {
err = ext4_handle_dirty_metadata(handle, NULL, bh);
if (err)
--
2.34.1

2023-01-02 16:51:00

by Jan Kara

Subject: Re: [PATCH] ext4: remove dead code in updating backup sb

On Fri 30-12-22 15:18:58, Tanmay Bhushan wrote:
> ext4_update_backup_sb checks for err having some value
> after unlocking buffer. But err has not been updated
> till that point in any code which will lead execution
> of the code in question.
>
> Signed-off-by: Tanmay Bhushan <[email protected]>

Looks good to me. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/ioctl.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
> index 8067ccda34e4..2e8c34036313 100644
> --- a/fs/ext4/ioctl.c
> +++ b/fs/ext4/ioctl.c
> @@ -155,9 +155,6 @@ static int ext4_update_backup_sb(struct super_block *sb,
> set_buffer_uptodate(bh);
> unlock_buffer(bh);
>
> - if (err)
> - goto out_bh;
> -
> if (handle) {
> err = ext4_handle_dirty_metadata(handle, NULL, bh);
> if (err)
> --
> 2.34.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2023-02-19 05:41:14

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove dead code in updating backup sb

On Fri, 30 Dec 2022 15:18:58 +0100, Tanmay Bhushan wrote:
> ext4_update_backup_sb checks for err having some value
> after unlocking buffer. But err has not been updated
> till that point in any code which will lead execution
> of the code in question.
>
>

Applied, thanks!

[1/1] ext4: remove dead code in updating backup sb
commit: 08abd0466ec9113908e674d042ec2a36dfc2875c

Best regards,
--
Theodore Ts'o <[email protected]>