2023-02-20 11:08:35

by Wu Bo

[permalink] [raw]
Subject: [PATCH] docs: ext4: modify the group desc size to 64

Since the default ext4 group desc size is 64 now and the size mentioned
in this doc is 64 too. Change it to 64.

Signed-off-by: Wu Bo <[email protected]>
---
Documentation/filesystems/ext4/blockgroup.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/filesystems/ext4/blockgroup.rst b/Documentation/filesystems/ext4/blockgroup.rst
index 46d78f860623..ed5a5cac6d40 100644
--- a/Documentation/filesystems/ext4/blockgroup.rst
+++ b/Documentation/filesystems/ext4/blockgroup.rst
@@ -105,9 +105,9 @@ descriptors. Instead, the superblock and a single block group descriptor
block is placed at the beginning of the first, second, and last block
groups in a meta-block group. A meta-block group is a collection of
block groups which can be described by a single block group descriptor
-block. Since the size of the block group descriptor structure is 32
-bytes, a meta-block group contains 32 block groups for filesystems with
-a 1KB block size, and 128 block groups for filesystems with a 4KB
+block. Since the size of the block group descriptor structure is 64
+bytes, a meta-block group contains 16 block groups for filesystems with
+a 1KB block size, and 64 block groups for filesystems with a 4KB
blocksize. Filesystems can either be created using this new block group
descriptor layout, or existing filesystems can be resized on-line, and
the field s_first_meta_bg in the superblock will indicate the first
--
2.35.3



2023-02-21 16:33:29

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] docs: ext4: modify the group desc size to 64

On Mon, Feb 20, 2023 at 07:06:37PM +0800, Wu Bo wrote:
> Since the default ext4 group desc size is 64 now and the size mentioned
> in this doc is 64 too. Change it to 64.
>
> Signed-off-by: Wu Bo <[email protected]>

Could you please a parenthetical comment: "(assuming that the 64-bit
feature is enbled)"?

Thanks!

- Ted