2023-06-22 16:57:32

by Jan Kara

Subject: [PATCH] ext4: Fix warning in blkdev_put()

ext4_blkdev_remove() passes a wrong holder pointer to blkdev_put() which
triggers a warning there. Fix it.

Fixes: 2736e8eeb0cc ("block: use the holder as indication for exclusive opens")
Signed-off-by: Jan Kara <[email protected]>
---
fs/ext4/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Jens, this is another fixup of the block device handling series sitting in
your tree.

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 53d74144ee34..d34b4eb90fe8 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1133,7 +1133,7 @@ static void ext4_blkdev_remove(struct ext4_sb_info *sbi)
struct block_device *bdev;
bdev = sbi->s_journal_bdev;
if (bdev) {
- blkdev_put(bdev, sbi->s_es);
+ blkdev_put(bdev, sbi->s_sb);
sbi->s_journal_bdev = NULL;
}
}
--
2.35.3

2023-06-23 06:28:27

by Christoph Hellwig

Subject: Re: [PATCH] ext4: Fix warning in blkdev_put()

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2023-06-23 14:41:51

by Jens Axboe

Subject: Re: [PATCH] ext4: Fix warning in blkdev_put()

On Thu, 22 Jun 2023 18:51:07 +0200, Jan Kara wrote:
> ext4_blkdev_remove() passes a wrong holder pointer to blkdev_put() which
> triggers a warning there. Fix it.
>
>

Applied, thanks!

[1/1] ext4: Fix warning in blkdev_put()
commit: a42fb5a75ccc37dfd69aa9bde5ba2866e802ff3c

Best regards,
--
Jens Axboe