2023-11-25 08:13:13

by Kemeng Shi

Subject: [PATCH 2/8] ext4: remove unused parameter group in ext4_mb_choose_next_group_*()

Remove unused parameter group in ext4_mb_choose_next_group_*().

Signed-off-by: Kemeng Shi <[email protected]>
---
fs/ext4/mballoc.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 9f9b8dd06..765b62729 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -870,7 +870,7 @@ mb_update_avg_fragment_size(struct super_block *sb, struct ext4_group_info *grp)
* cr level needs an update.
*/
static void ext4_mb_choose_next_group_p2_aligned(struct ext4_allocation_context *ac,
- enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
+ enum criteria *new_cr, ext4_group_t *group)
{
struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
struct ext4_group_info *iter;
@@ -944,7 +944,7 @@ ext4_mb_find_good_group_avg_frag_lists(struct ext4_allocation_context *ac, int o
* order. Updates *new_cr if cr level needs an update.
*/
static void ext4_mb_choose_next_group_goal_fast(struct ext4_allocation_context *ac,
- enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
+ enum criteria *new_cr, ext4_group_t *group)
{
struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
struct ext4_group_info *grp = NULL;
@@ -989,7 +989,7 @@ static void ext4_mb_choose_next_group_goal_fast(struct ext4_allocation_context *
* much and fall to CR_GOAL_LEN_SLOW in that case.
*/
static void ext4_mb_choose_next_group_best_avail(struct ext4_allocation_context *ac,
- enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
+ enum criteria *new_cr, ext4_group_t *group)
{
struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
struct ext4_group_info *grp = NULL;
@@ -1124,11 +1124,11 @@ static void ext4_mb_choose_next_group(struct ext4_allocation_context *ac,
}

if (*new_cr == CR_POWER2_ALIGNED) {
- ext4_mb_choose_next_group_p2_aligned(ac, new_cr, group, ngroups);
+ ext4_mb_choose_next_group_p2_aligned(ac, new_cr, group);
} else if (*new_cr == CR_GOAL_LEN_FAST) {
- ext4_mb_choose_next_group_goal_fast(ac, new_cr, group, ngroups);
+ ext4_mb_choose_next_group_goal_fast(ac, new_cr, group);
} else if (*new_cr == CR_BEST_AVAIL_LEN) {
- ext4_mb_choose_next_group_best_avail(ac, new_cr, group, ngroups);
+ ext4_mb_choose_next_group_best_avail(ac, new_cr, group);
} else {
/*
* TODO: For CR=2, we can arrange groups in an rb tree sorted by
--
2.30.0

2024-01-02 13:01:54

by Jan Kara

Subject: Re: [PATCH 2/8] ext4: remove unused parameter group in ext4_mb_choose_next_group_*()

On Sun 26-11-23 00:11:37, Kemeng Shi wrote:
> Remove unused parameter group in ext4_mb_choose_next_group_*().
>
> Signed-off-by: Kemeng Shi <[email protected]>

Makes sense. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/mballoc.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 9f9b8dd06..765b62729 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -870,7 +870,7 @@ mb_update_avg_fragment_size(struct super_block *sb, struct ext4_group_info *grp)
> * cr level needs an update.
> */
> static void ext4_mb_choose_next_group_p2_aligned(struct ext4_allocation_context *ac,
> - enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
> + enum criteria *new_cr, ext4_group_t *group)
> {
> struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
> struct ext4_group_info *iter;
> @@ -944,7 +944,7 @@ ext4_mb_find_good_group_avg_frag_lists(struct ext4_allocation_context *ac, int o
> * order. Updates *new_cr if cr level needs an update.
> */
> static void ext4_mb_choose_next_group_goal_fast(struct ext4_allocation_context *ac,
> - enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
> + enum criteria *new_cr, ext4_group_t *group)
> {
> struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
> struct ext4_group_info *grp = NULL;
> @@ -989,7 +989,7 @@ static void ext4_mb_choose_next_group_goal_fast(struct ext4_allocation_context *
> * much and fall to CR_GOAL_LEN_SLOW in that case.
> */
> static void ext4_mb_choose_next_group_best_avail(struct ext4_allocation_context *ac,
> - enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
> + enum criteria *new_cr, ext4_group_t *group)
> {
> struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
> struct ext4_group_info *grp = NULL;
> @@ -1124,11 +1124,11 @@ static void ext4_mb_choose_next_group(struct ext4_allocation_context *ac,
> }
>
> if (*new_cr == CR_POWER2_ALIGNED) {
> - ext4_mb_choose_next_group_p2_aligned(ac, new_cr, group, ngroups);
> + ext4_mb_choose_next_group_p2_aligned(ac, new_cr, group);
> } else if (*new_cr == CR_GOAL_LEN_FAST) {
> - ext4_mb_choose_next_group_goal_fast(ac, new_cr, group, ngroups);
> + ext4_mb_choose_next_group_goal_fast(ac, new_cr, group);
> } else if (*new_cr == CR_BEST_AVAIL_LEN) {
> - ext4_mb_choose_next_group_best_avail(ac, new_cr, group, ngroups);
> + ext4_mb_choose_next_group_best_avail(ac, new_cr, group);
> } else {
> /*
> * TODO: For CR=2, we can arrange groups in an rb tree sorted by
> --
> 2.30.0
>
>
--
Jan Kara <[email protected]>
SUSE Labs, CR