2023-11-25 08:13:13

by Kemeng Shi

Subject: [PATCH 4/8] ext4: remove unused ext4_allocation_context::ac_groups_considered

Remove unused ext4_allocation_context::ac_groups_considered

Signed-off-by: Kemeng Shi <[email protected]>
---
fs/ext4/mballoc.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index d7aeb5da7..56938532b 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -192,7 +192,6 @@ struct ext4_allocation_context {
*/
ext4_grpblk_t ac_orig_goal_len;

- __u32 ac_groups_considered;
__u32 ac_flags; /* allocation hints */
__u16 ac_groups_scanned;
__u16 ac_groups_linear_remaining;
--
2.30.0

2024-01-02 13:03:55

by Jan Kara

Subject: Re: [PATCH 4/8] ext4: remove unused ext4_allocation_context::ac_groups_considered

On Sun 26-11-23 00:11:39, Kemeng Shi wrote:
> Remove unused ext4_allocation_context::ac_groups_considered
>
> Signed-off-by: Kemeng Shi <[email protected]>

Hum, indeed. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/mballoc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
> index d7aeb5da7..56938532b 100644
> --- a/fs/ext4/mballoc.h
> +++ b/fs/ext4/mballoc.h
> @@ -192,7 +192,6 @@ struct ext4_allocation_context {
> */
> ext4_grpblk_t ac_orig_goal_len;
>
> - __u32 ac_groups_considered;
> __u32 ac_flags; /* allocation hints */
> __u16 ac_groups_scanned;
> __u16 ac_groups_linear_remaining;
> --
> 2.30.0
>
>
--
Jan Kara <[email protected]>
SUSE Labs, CR