2023-11-25 08:13:19

by Kemeng Shi

Subject: [PATCH 6/8] ext4: remove unused return value of ext4_mb_release_inode_pa

Remove unused return value of ext4_mb_release_inode_pa

Signed-off-by: Kemeng Shi <[email protected]>
---
fs/ext4/mballoc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 8d6246db3..1ed6d1d5a 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -5278,7 +5278,7 @@ static void ext4_mb_new_preallocation(struct ext4_allocation_context *ac)
* the caller MUST hold group/inode locks.
* TODO: optimize the case when there are no in-core structures yet
*/
-static noinline_for_stack int
+static noinline_for_stack void
ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh,
struct ext4_prealloc_space *pa)
{
@@ -5328,8 +5328,6 @@ ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh,
*/
}
atomic_add(free, &sbi->s_mb_discarded);
-
- return 0;
}

static noinline_for_stack int
--
2.30.0

2024-01-02 13:07:01

by Jan Kara

Subject: Re: [PATCH 6/8] ext4: remove unused return value of ext4_mb_release_inode_pa

On Sun 26-11-23 00:11:41, Kemeng Shi wrote:
> Remove unused return value of ext4_mb_release_inode_pa
>
> Signed-off-by: Kemeng Shi <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/mballoc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 8d6246db3..1ed6d1d5a 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -5278,7 +5278,7 @@ static void ext4_mb_new_preallocation(struct ext4_allocation_context *ac)
> * the caller MUST hold group/inode locks.
> * TODO: optimize the case when there are no in-core structures yet
> */
> -static noinline_for_stack int
> +static noinline_for_stack void
> ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh,
> struct ext4_prealloc_space *pa)
> {
> @@ -5328,8 +5328,6 @@ ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh,
> */
> }
> atomic_add(free, &sbi->s_mb_discarded);
> -
> - return 0;
> }
>
> static noinline_for_stack int
> --
> 2.30.0
>
>
--
Jan Kara <[email protected]>
SUSE Labs, CR