2024-05-06 17:41:45

by Jan Kara

[permalink] [raw]
Subject: [PATCH 3/3] e2fsck: fix golden output of several tests

Some old tests of EA inodes were not in fact completely fixing the
filesystem (like they were leaving directories with EA_INODE_FL set or
EA inodes referenced from directory hierarchy). New e2fsck checks fix
these so golden output changes. Update it.

Signed-off-by: Jan Kara <[email protected]>
---
tests/f_bad_disconnected_inode/expect.1 | 8 ++++++++
tests/f_bad_fname/expect.1 | 2 ++
tests/f_ea_inode_self_ref/expect.1 | 2 ++
3 files changed, 12 insertions(+)

diff --git a/tests/f_bad_disconnected_inode/expect.1 b/tests/f_bad_disconnected_inode/expect.1
index d1479cef2880..39c6958cfa8d 100644
--- a/tests/f_bad_disconnected_inode/expect.1
+++ b/tests/f_bad_disconnected_inode/expect.1
@@ -1,11 +1,17 @@
Pass 1: Checking inodes, blocks, and sizes
+Inode 1 has the ea_inode flag set but is not a regular file. Clear flag? yes
+
Inode 1 has EXTENTS_FL flag set on filesystem without extents support.
Clear? yes

Inode 9 has the casefold flag set but is not a directory. Clear flag? yes

+Inode 10 has the ea_inode flag set but is not a regular file. Clear flag? yes
+
Inode 14 has the casefold flag set but is not a directory. Clear flag? yes

+Inode 14 has the ea_inode flag set but is not a regular file. Clear flag? yes
+
Inode 14 has INLINE_DATA_FL flag on filesystem without inline data support.
Clear? yes

@@ -14,6 +20,8 @@ Clear? yes

Inode 16 has the casefold flag set but is not a directory. Clear flag? yes

+Inode 16 has the ea_inode flag set but is not a regular file. Clear flag? yes
+
Inode 16 has INLINE_DATA_FL flag on filesystem without inline data support.
Clear? yes

diff --git a/tests/f_bad_fname/expect.1 b/tests/f_bad_fname/expect.1
index 66f87df2b810..60f64f67d462 100644
--- a/tests/f_bad_fname/expect.1
+++ b/tests/f_bad_fname/expect.1
@@ -1,4 +1,6 @@
Pass 1: Checking inodes, blocks, and sizes
+Inode 12 has the ea_inode flag set but is not a regular file. Clear flag? yes
+
Pass 2: Checking directory structure
Entry 'AM-^?' in /ci_dir (12) has illegal UTF-8 characters in its name.
Fix? yes
diff --git a/tests/f_ea_inode_self_ref/expect.1 b/tests/f_ea_inode_self_ref/expect.1
index f94c04d966e5..35bea1417405 100644
--- a/tests/f_ea_inode_self_ref/expect.1
+++ b/tests/f_ea_inode_self_ref/expect.1
@@ -7,6 +7,8 @@ Clear? yes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
Pass 4: Checking reference counts
+Regular filesystem inode 16 has EA_INODE flag set. Clear? yes
+
Pass 5: Checking group summary information
Block bitmap differences: -20
Fix? yes
--
2.35.3