2024-06-06 12:56:31

by Kemeng Shi

Subject: [PATCH 0/3] Some extended attributes related comments correction

Some extended attributes related comments correction. Please see
repective patches for detail. Thanks.

Kemeng Shi (3):
ext4: correct comment of ext4_xattr_cmp
ext4: correct comment of ext4_xattr_block_cache_insert
ext4: correct comment of h_checksum

fs/ext4/xattr.c | 5 +----
fs/ext4/xattr.h | 3 +--
2 files changed, 2 insertions(+), 6 deletions(-)

--
2.30.0

2024-06-06 12:56:40

by Kemeng Shi

Subject: [PATCH 1/3] ext4: correct comment of ext4_xattr_cmp

The ext4_xattr_cmp never returns negative error number. Correct possible
return value in ext4_xattr_cmp's comment.

Signed-off-by: Kemeng Shi <[email protected]>
---
fs/ext4/xattr.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index b67a176bfcf9..c3db1abe9d77 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -3050,8 +3050,7 @@ ext4_xattr_block_cache_insert(struct mb_cache *ea_block_cache,
*
* Compare two extended attribute blocks for equality.
*
- * Returns 0 if the blocks are equal, 1 if they differ, and
- * a negative error number on errors.
+ * Returns 0 if the blocks are equal, 1 if they differ.
*/
static int
ext4_xattr_cmp(struct ext4_xattr_header *header1,
--
2.30.0