2024-04-11 18:28:39

by Kent Overstreet

[permalink] [raw]
Subject: Re: [PATCH RFC v3 for-6.8/block 07/17] bcachefs: remove dead function bdev_sectors()

On Thu, Dec 21, 2023 at 04:57:02PM +0800, Yu Kuai wrote:
> From: Yu Kuai <[email protected]>
>
> bdev_sectors() is not used hence remove it.
>
> Signed-off-by: Yu Kuai <[email protected]>

Acked-by: Kent Overstreet <[email protected]>

> ---
> fs/bcachefs/util.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/bcachefs/util.h b/fs/bcachefs/util.h
> index 2984b57b2958..22a0acc1704f 100644
> --- a/fs/bcachefs/util.h
> +++ b/fs/bcachefs/util.h
> @@ -516,11 +516,6 @@ static inline unsigned fract_exp_two(unsigned x, unsigned fract_bits)
> void bch2_bio_map(struct bio *bio, void *base, size_t);
> int bch2_bio_alloc_pages(struct bio *, size_t, gfp_t);
>
> -static inline sector_t bdev_sectors(struct block_device *bdev)
> -{
> - return bdev->bd_inode->i_size >> 9;
> -}
> -
> #define closure_bio_submit(bio, cl) \
> do { \
> closure_get(cl); \
> --
> 2.39.2
>