2022-04-15 02:14:47

by Darrick J. Wong

[permalink] [raw]
Subject: Re: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix

On Fri, Apr 15, 2022 at 12:50:56AM +0000, Matthew G McGovern wrote:
> From: "Matthew G. McGovern" <[email protected]>
> Date: Wed, 13 Apr 2022 15:48:15 -0700
> Subject: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix
>
> An ext4 struct has the wrong array size for a field in the docs.
>
> - Document correct array size (3) for ext4_xattr_header.h_reserved
>
> Signed-off-by: Matthew G. McGovern <[email protected]>

Yup. Thanks for the correction.

Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> Documentation/filesystems/ext4/attributes.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/ext4/attributes.rst b/Documentation/filesystems/ext4/attributes.rst
> index 54386a010a8d..871d2da7a0a9 100644
> --- a/Documentation/filesystems/ext4/attributes.rst
> +++ b/Documentation/filesystems/ext4/attributes.rst
> @@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
> - Checksum of the extended attribute block.
> * - 0x14
> - \_\_u32
> - - h\_reserved[2]
> + - h\_reserved[3]
> - Zero.
>
> The checksum is calculated against the FS UUID, the 64-bit block number
>
> base-commit: 96485e4462604744d66bf4301557d996d80b85eb
> --
> 2.25.1


2022-04-16 02:51:34

by wangjianjian (C)

[permalink] [raw]
Subject: Re: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix

I submitted a similar patch fixed this and it should have already been
in Ted's tree ?

2022-04-19 00:45:06

by Matthew G McGovern

[permalink] [raw]
Subject: Re: [PATCH] Ext4 Documentation: ext4_xattr_header struct size fix

However the fix gets into main is fine with me, it is not in the working tree or linux-next currently. Can someone commit to getting one of these patches in? This is my first submission so I'm not sure who needs to apply and submit exactly.

-mm


On Fri, Apr 15, 2022 at 6:07 PM, wangjianjian (C) <[email protected]> wrote:

> I submitted a similar patch fixed this and it should have already been
> in Ted's tree ?