2023-11-20 19:06:02

by Ritesh Harjani (IBM)

Subject: [RFC 3/3] ext2: Enable large folio support

Now that ext2 regular file buffered-io path is converted to use iomap,
we can also enable large folio support for ext2.

Signed-off-by: Ritesh Harjani (IBM) <[email protected]>
---
fs/ext2/inode.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index b6224d94a7dd..ad04da5ed6bd 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -1425,10 +1425,12 @@ void ext2_set_file_ops(struct inode *inode)
{
inode->i_op = &ext2_file_inode_operations;
inode->i_fop = &ext2_file_operations;
- if (IS_DAX(inode))
+ if (IS_DAX(inode)) {
inode->i_mapping->a_ops = &ext2_dax_aops;
- else
+ } else {
inode->i_mapping->a_ops = &ext2_file_aops;
+ mapping_set_large_folios(inode->i_mapping);
+ }
}

struct inode *ext2_iget (struct super_block *sb, unsigned long ino)
--
2.41.0

2023-11-20 20:01:29

by Matthew Wilcox

Subject: Re: [RFC 3/3] ext2: Enable large folio support

On Tue, Nov 21, 2023 at 12:35:21AM +0530, Ritesh Harjani (IBM) wrote:
> Now that ext2 regular file buffered-io path is converted to use iomap,
> we can also enable large folio support for ext2.

Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>