2018-11-01 04:12:08

by Vasily Averin

Subject: [PATCH 4/7] ext4: lost brelse in ext4_xattr_get_block()

Fixes dec214d00e0d ("ext4: xattr inode deduplication") # 4.13

Signed-off-by: Vasily Averin <[email protected]>
---
fs/ext4/xattr.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index dc1aeab06dba..07c3a115f7ae 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -2272,8 +2272,10 @@ static struct buffer_head *ext4_xattr_get_block(struct inode *inode)
if (!bh)
return ERR_PTR(-EIO);
error = ext4_xattr_check_block(inode, bh);
- if (error)
+ if (error) {
+ brelse(bh);
return ERR_PTR(error);
+ }
return bh;
}

--
2.17.1

2018-11-08 01:33:40

by Theodore Ts'o

Subject: Re: [PATCH 4/7] ext4: lost brelse in ext4_xattr_get_block()

On Wed, Oct 31, 2018 at 10:12:43PM +0300, Vasily Averin wrote:
> Fixes dec214d00e0d ("ext4: xattr inode deduplication") # 4.13
>
> Signed-off-by: Vasily Averin <[email protected]>

Thanks, applied. I used the description line:

ext4: fix buffer leak in ext4_xattr_get_block() on error path

- Ted