2007-10-15 14:16:51

by Coly Li

Subject: [PATCH][e2fsprogs] add -E option to mke2fs usage information

-E option is missed from usage information of mke2fs. This patch adds -E option to usage
information, and names -E|-R as extended-option.
Now the usage information can be consistent with mke2fs.8.in.

Signed-off-by: Coly Li <[email protected]>
---
misc/mke2fs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 4a6cace..128aa43 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -100,7 +100,7 @@ static void usage(void)
"\t[-N number-of-inodes] [-m reserved-blocks-percentage] "
"[-o creator-os]\n\t[-g blocks-per-group] [-L volume-label] "
"[-M last-mounted-directory]\n\t[-O feature[,...]] "
- "[-r fs-revision] [-R options] [-qvSV]\n\tdevice [blocks-count]\n"),
+ "[-r fs-revision] [-E|-R extended-option[,...]] [-qvSV]\n\tdevice [blocks-count]\n"),
program_name);
exit(1);
}

--
Coly Li
SuSE PRC Labs

2007-10-15 21:01:27

by Theodore Ts'o

Subject: Re: [PATCH][e2fsprogs] add -E option to mke2fs usage information

On Mon, Oct 15, 2007 at 10:19:11PM +0800, Coly Li wrote:
> -E option is missed from usage information of mke2fs. This patch adds -E option to usage
> information, and names -E|-R as extended-option.
> Now the usage information can be consistent with mke2fs.8.in.

Please fill comments to 80 columns; thanks!!

I checked this into the maint branch, but I just changed the message
to use -E only. The use of -R is deprecated, but supported for
backwards compatibility; so there's no point putting it in the usage
message.

- Ted

2007-10-16 03:19:17

by Coly Li

Subject: Re: [PATCH][e2fsprogs] add -E option to mke2fs usage information

Theodore Tso wrote:
> On Mon, Oct 15, 2007 at 10:19:11PM +0800, Coly Li wrote:
>> -E option is missed from usage information of mke2fs. This patch adds -E option to usage
>> information, and names -E|-R as extended-option.
>> Now the usage information can be consistent with mke2fs.8.in.
>
> Please fill comments to 80 columns; thanks!!
I will note this in future patches :-)

>
> I checked this into the maint branch, but I just changed the message
> to use -E only. The use of -R is deprecated, but supported for
> backwards compatibility; so there's no point putting it in the usage
> message.

Thanks for the message :-)

>
> - Ted

2007-10-16 03:20:33

by Coly Li

Subject: Re: [PATCH][e2fsprogs] add -E option to mke2fs usage information

Theodore Tso wrote:
> On Mon, Oct 15, 2007 at 10:19:11PM +0800, Coly Li wrote:
>> -E option is missed from usage information of mke2fs. This patch adds -E option to usage
>> information, and names -E|-R as extended-option.
>> Now the usage information can be consistent with mke2fs.8.in.
>
> Please fill comments to 80 columns; thanks!!

I will follow this in future patches :-)
>
> I checked this into the maint branch, but I just changed the message
> to use -E only. The use of -R is deprecated, but supported for
> backwards compatibility; so there's no point putting it in the usage
> message.

Thanks for the message :-)
>
> - Ted