2008-05-15 23:38:36

by Andrew Morton

Subject: Re: ［PATCH] ext4: fix error ext number comments

On Thu, 15 May 2008 10:21:27 +0800
Shen Feng <[email protected]> wrote:

> Subject: ［PATCH] ext4: fix error ext number comments

Oh dear. When my eail client (sylpheed) saves this email to a file I get

Subject: =?GB2312?B?o9tQQVRDSF0gZXh0NDogZml4IGVycm9yIGV4dCBudW1iZXIgY29tbQ==?=
=?GB2312?B?ZW50cw==?=


This can only increase. Sigh, life used to be simple.

2008-05-15 23:50:35

by Theodore Ts'o

Subject: Re: ［PATCH ] ext4: fix error ext number comments

On Thu, May 15, 2008 at 04:38:31PM -0700, Andrew Morton wrote:
> On Thu, 15 May 2008 10:21:27 +0800
> Shen Feng <[email protected]> wrote:
>
> > Subject: ［PATCH] ext4: fix error ext number comments
>
> Oh dear. When my eail client (sylpheed) saves this email to a file I get
>
> Subject: =?GB2312?B?o9tQQVRDSF0gZXh0NDogZml4IGVycm9yIGV4dCBudW1iZXIgY29tbQ==?=
> =?GB2312?B?ZW50cw==?=
>
>
> This can only increase. Sigh, life used to be simple.

This message aparently never made it to the linux-ext4 mailing list.
It's not in my inbox or in my linux-ext4 archive (although your reply
has made it there). I wonder if the vger dropped it as "chinese
spam". :-)

Could you forward it, please?

- Ted

2008-05-16 02:53:06

by Shen Feng

Subject: Re: [PATCH] ext4: fix error ext number comments

Andrew Morton Wrote:
> On Thu, 15 May 2008 10:21:27 +0800
> Shen Feng <[email protected]> wrote:
>
>> Subject: [PATCH] ext4: fix error ext number comments
>
> Oh dear. When my eail client (sylpheed) saves this email to a file I get
>
> Subject: =?GB2312?B?o9tQQVRDSF0gZXh0NDogZml4IGVycm9yIGV4dCBudW1iZXIgY29tbQ==?=
> =?GB2312?B?ZW50cw==?=
>
>
> This can only increase. Sigh, life used to be simple.
>
>

It seems that there is a coding problem.
Sorry for that. And the fix is not complete and here is the new one.

ext4: fix error ext number comments

Change second/third to fourth.

Signed-off-by: Shen Feng <[email protected]>
---
fs/ext4/ext4.h | 2 +-
fs/ext4/ext4_i.h | 2 +-
fs/ext4/ext4_sb.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 8158083..f8e22e4 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -22,7 +22,7 @@
#include "ext4_i.h"

/*
- * The second extended filesystem constants/structures
+ * The fourth extended filesystem constants/structures
*/

/*
diff --git a/fs/ext4/ext4_i.h b/fs/ext4/ext4_i.h
index 26a4ae2..abf2744 100644
--- a/fs/ext4/ext4_i.h
+++ b/fs/ext4/ext4_i.h
@@ -79,7 +79,7 @@ struct ext4_ext_cache {
};

/*
- * third extended file system inode data in memory
+ * fourth extended file system inode data in memory
*/
struct ext4_inode_info {
__le32 i_data[15]; /* unconverted */
diff --git a/fs/ext4/ext4_sb.h b/fs/ext4/ext4_sb.h
index 5802e69..4de9a75 100644
--- a/fs/ext4/ext4_sb.h
+++ b/fs/ext4/ext4_sb.h
@@ -25,7 +25,7 @@
#include <linux/rbtree.h>

/*
- * third extended-fs super-block data in memory
+ * fourth extended-fs super-block data in memory
*/
struct ext4_sb_info {
unsigned long s_desc_size; /* Size of a group descriptor in bytes */
-- 1.5.4.1