2009-07-06 08:20:54

by Kazuya Mio

[permalink] [raw]
Subject: [PATCH 3/3] e2fsck: Remove unused variable

check_block_bitmap() calculates the block number of superblock in the current
block group but it's not used.

Regards,
Kazuya Mio

Signed-off-by: Kazuya Mio <[email protected]>
---
pass5.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/e2fsck/pass5.c b/e2fsck/pass5.c
index e660386..29930cc 100644
--- a/e2fsck/pass5.c
+++ b/e2fsck/pass5.c
@@ -103,7 +103,7 @@ static void print_bitmap_problem(e2fsck_t ctx, int problem,
static void check_block_bitmaps(e2fsck_t ctx)
{
ext2_filsys fs = ctx->fs;
- blk_t i, super;
+ blk_t i;
int *free_array;
int group = 0;
blk_t blocks = 0;
@@ -159,7 +159,6 @@ redo_counts:
if (csum_flag &&
(fs->group_desc[group].bg_flags & EXT2_BG_BLOCK_UNINIT))
skip_group++;
- super = fs->super->s_first_data_block;
for (i = fs->super->s_first_data_block;
i < fs->super->s_blocks_count;
i++) {
@@ -255,7 +254,6 @@ redo_counts:
blocks = 0;
group_free = 0;
skip_group = 0;
- super += fs->super->s_blocks_per_group;
if (ctx->progress)
if ((ctx->progress)(ctx, 5, group,
fs->group_desc_count*2))


2009-07-07 03:25:07

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH 3/3] e2fsck: Remove unused variable

On Mon, Jul 06, 2009 at 05:16:32PM +0900, Kazuya Mio wrote:
> check_block_bitmap() calculates the block number of superblock in the
> current block group but it's not used.

Thanks, applied.

- Ted