2010-09-08 05:56:50

by Kazuya Mio

Subject: [PATCH] Fix compile error in ext4_fallocate()

Hi,

When I compiled 2.6.36-rc3 kernel with EXT4FS_DEBUG definition, I got the
following compile error.

CC [M] fs/ext4/extents.o
fs/ext4/extents.c: In function 'ext4_fallocate':
fs/ext4/extents.c:3772: error: 'block' undeclared (first use in this function)
fs/ext4/extents.c:3772: error: (Each undeclared identifier is reported only once
fs/ext4/extents.c:3772: error: for each function it appears in.)
make[2]: *** [fs/ext4/extents.o] Error 1

The patch fixes this problem.

Signed-off-by: Kazuya Mio <[email protected]>
---
fs/ext4/extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 8202784..590caa3 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3769,7 +3769,7 @@ retry:
printk(KERN_ERR "%s: ext4_ext_map_blocks "
"returned error inode#%lu, block=%u, "
"max_blocks=%u", __func__,
- inode->i_ino, block, max_blocks);
+ inode->i_ino, map.m_lblk, max_blocks);
#endif
ext4_mark_inode_dirty(handle, inode);
ret2 = ext4_journal_stop(handle);

2010-10-27 20:33:17

by Theodore Ts'o

Subject: Re: [PATCH] Fix compile error in ext4_fallocate()

On Wed, Sep 08, 2010 at 02:54:14PM +0900, Kazuya Mio wrote:
> Hi,
>
> When I compiled 2.6.36-rc3 kernel with EXT4FS_DEBUG definition, I got the
> following compile error.

I've applied this fix to the ext4 patch queue. Many thanks for the patch!!

- Ted