2010-10-15 11:03:13

by Namhyung Kim

Subject: [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate()

Signed-off-by: Namhyung Kim <[email protected]>
---
fs/ext3/inode.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 5e0faf4..90a9c3d 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -2530,7 +2530,6 @@ void ext3_truncate(struct inode *inode)
*/
} else {
/* Shared branch grows from an indirect block */
- BUFFER_TRACE(partial->bh, "get_write_access");
ext3_free_branches(handle, inode, partial->bh,
partial->p,
partial->p+1, (chain+n-1) - partial);
--
1.7.0.4

2010-10-18 10:55:21

by Jan Kara

Subject: Re: [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate()

On Fri 15-10-10 20:03:02, Namhyung Kim wrote:
> Signed-off-by: Namhyung Kim <[email protected]>
Thanks. Merged.

Honza
> ---
> fs/ext3/inode.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
> index 5e0faf4..90a9c3d 100644
> --- a/fs/ext3/inode.c
> +++ b/fs/ext3/inode.c
> @@ -2530,7 +2530,6 @@ void ext3_truncate(struct inode *inode)
> */
> } else {
> /* Shared branch grows from an indirect block */
> - BUFFER_TRACE(partial->bh, "get_write_access");
> ext3_free_branches(handle, inode, partial->bh,
> partial->p,
> partial->p+1, (chain+n-1) - partial);
> --
> 1.7.0.4
>
--
Jan Kara <[email protected]>
SUSE Labs, CR

2010-10-18 14:22:46

by Eric Sandeen

Subject: Re: [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate()

Namhyung Kim wrote:
> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> fs/ext3/inode.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
> index 5e0faf4..90a9c3d 100644
> --- a/fs/ext3/inode.c
> +++ b/fs/ext3/inode.c
> @@ -2530,7 +2530,6 @@ void ext3_truncate(struct inode *inode)
> */
> } else {
> /* Shared branch grows from an indirect block */
> - BUFFER_TRACE(partial->bh, "get_write_access");
> ext3_free_branches(handle, inode, partial->bh,
> partial->p,
> partial->p+1, (chain+n-1) - partial);

As long as you're doing these cleanups, you may as well eyeball ext4
to see whether the same issues exist; in the case above, it does, and the
exact same patch (modulo ext3/ext4 changes) applies.

No real point in getting ext3 fixed up and leaving ext4 behind...

Thanks,
-Eric

2010-10-18 14:53:22

by Namhyung Kim

Subject: Re: [PATCH] ext3: Remove misplaced BUFFER_TRACE() in ext3_truncate()

2010-10-18 (월), 09:22 -0500, Eric Sandeen:
> As long as you're doing these cleanups, you may as well eyeball ext4
> to see whether the same issues exist; in the case above, it does, and the
> exact same patch (modulo ext3/ext4 changes) applies.
>
> No real point in getting ext3 fixed up and leaving ext4 behind...
>

My plan was sending those patches in a batch after reading ext3 at all.
But it seems to take some time, so now I think that it'd be better to
send them in a small series. I'll prepare it for ext4 (and ext2 too if
you want, Jan) soon. Thanks.

--
Regards,
Namhyung Kim