memset is needless because path is allocated by kzalloc.
Signed-off-by: Peter Pan(潘卫平) <[email protected]>
---
fs/ext4/extents.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 0554c48..37cdb6e 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2375,7 +2375,6 @@ again:
/* go to the next level */
ext_debug("move to level %d (block %llu)\n",
i + 1, ext4_idx_pblock(path[i].p_idx));
- memset(path + i + 1, 0, sizeof(*path));
bh = sb_bread(sb, ext4_idx_pblock(path[i].p_idx));
if (!bh) {
/* should we reset i_size? */
--
1.6.6
On Mon, Nov 08, 2010 at 09:19:47AM +0800, "潘卫平(Peter Pan)" wrote:
>
> memset is needless because path is allocated by kzalloc.
>
This is inside a loop and sometimes we do i++ and sometimes i--. Are
you absolutely positive that path + i isn't initialized?
I haven't followed this code through all the way but my instinct is
that the memset is there for a reason.
regards,
dan carpenter
On 2010年11月08日 12:37, Dan Carpenter wrote:
> This is inside a loop and sometimes we do i++ and sometimes i--. Are
> you absolutely positive that path + i isn't initialized?
>
> I haven't followed this code through all the way but my instinct is
> that the memset is there for a reason.
>
I know that I misunderstood it.
Thank you!
Regards
Peter Pan