2012-07-06 06:26:37

by Wang Sheng-Hui

Subject: [PATCH 1/2] ext4: fix the comment in ext4_ext_insert_extent for ext4_ext_try_to_merge in extents.c

The left and right extents merge is done by
ext4_ext_try_to_merge. No specific left/right
fun calls any more.

Signed-off-by: Wang Sheng-Hui <[email protected]>
---
fs/ext4/extents.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 5207b7b..6c2a37d 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1891,12 +1891,10 @@ has_space:
nearex->ee_len = newext->ee_len;

merge:
- /* try to merge extents to the right */
+ /* try to merge extents to the neighbours */
if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
ext4_ext_try_to_merge(inode, path, nearex);

- /* try to merge extents to the left */

2012-07-07 15:15:07

by Zheng Liu

Subject: Re: [PATCH 1/2] ext4: fix the comment in ext4_ext_insert_extent for ext4_ext_try_to_merge in extents.c

Hi Sheng-Hui,

It seems that there has a patch to fix it.
http://www.spinics.net/lists/linux-ext4/msg32611.html

Regards,
Zheng

On Fri, Jul 6, 2012 at 2:26 PM, Wang Sheng-Hui <[email protected]> wrote:
> The left and right extents merge is done by
> ext4_ext_try_to_merge. No specific left/right
> fun calls any more.
>
> Signed-off-by: Wang Sheng-Hui <[email protected]>
> ---
> fs/ext4/extents.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 5207b7b..6c2a37d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1891,12 +1891,10 @@ has_space:
> nearex->ee_len = newext->ee_len;
>
> merge:
> - /* try to merge extents to the right */
> + /* try to merge extents to the neighbours */
> if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
> ext4_ext_try_to_merge(inode, path, nearex);
>
> - /* try to merge extents to the left */
> -
> /* time to correct all indexes above */
> err = ext4_ext_correct_indexes(handle, inode, path);
> if (err)
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2012-07-08 10:38:53

by Wang Sheng-Hui

Subject: Re: [PATCH 1/2] ext4: fix the comment in ext4_ext_insert_extent for ext4_ext_try_to_merge in extents.c

On 2012年07月07日 23:15, Zheng Liu wrote:
> Hi Sheng-Hui,
>
> It seems that there has a patch to fix it.
> http://www.spinics.net/lists/linux-ext4/msg32611.html
>
> Regards,
> Zheng

Got it.

I didn't track the patch list. Just checked the git tree.

Thanks,

>
> On Fri, Jul 6, 2012 at 2:26 PM, Wang Sheng-Hui <[email protected]> wrote:
>> The left and right extents merge is done by
>> ext4_ext_try_to_merge. No specific left/right
>> fun calls any more.
>>
>> Signed-off-by: Wang Sheng-Hui <[email protected]>
>> ---
>> fs/ext4/extents.c | 4 +---
>> 1 files changed, 1 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
>> index 5207b7b..6c2a37d 100644
>> --- a/fs/ext4/extents.c
>> +++ b/fs/ext4/extents.c
>> @@ -1891,12 +1891,10 @@ has_space:
>> nearex->ee_len = newext->ee_len;
>>
>> merge:
>> - /* try to merge extents to the right */
>> + /* try to merge extents to the neighbours */
>> if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
>> ext4_ext_try_to_merge(inode, path, nearex);
>>
>> - /* try to merge extents to the left */
>> -
>> /* time to correct all indexes above */
>> err = ext4_ext_correct_indexes(handle, inode, path);
>> if (err)
>> --
>> 1.7.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html