2012-06-21 13:23:22

by Haibo

Subject: [PATCH][v2] ext4: change a comment on fs/ext4/extents.c

From: HaiboLiu <[email protected]>

In this patch, ext4_ext_try_to_merge has been change to merge
an extent both left and right. So we need to update the comment
in here.

v1->v2: update the subject and the patch comment.

Signed-off-by: HaiboLiu <[email protected]>
---
fs/ext4/extents.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 74f23c2..db671b9 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1807,11 +1807,10 @@ has_space:
nearex->ee_len = newext->ee_len;

merge:
- /* try to merge extents to the right */
+ /* try to merge extents */
if (!(flag & EXT4_GET_BLOCKS_PRE_IO))
ext4_ext_try_to_merge(inode, path, nearex);

- /* try to merge extents to the left */

/* time to correct all indexes above */
err = ext4_ext_correct_indexes(handle, inode, path);
--
1.7.9.5

2012-07-09 14:21:22

by Theodore Ts'o

Subject: Re: [v2] ext4: change a comment on fs/ext4/extents.c

On Thu, Jun 21, 2012 at 03:23:14AM -0000, Liu Haibo wrote:
> From: HaiboLiu <[email protected]>
>
> In this patch, ext4_ext_try_to_merge has been change to merge
> an extent both left and right. So we need to update the comment
> in here.
>
> v1->v2: update the subject and the patch comment.
>
> Signed-off-by: HaiboLiu <[email protected]>

Applied, thanks.

BTW, in the future, it's better to put the v1-v2 log after the "---"
separator.

- Ted