2012-07-23 08:03:26

by Wang Sheng-Hui

Subject: [PATCH] ext4: remove redundant offset check in move_extents.c/mext_check_arguments

In the check code above, if orig_start != donor_start, we would
return -EINVAL. So here, orig_start should be equal with donor_start.
Remove the redundant check here.

Signed-off-by: Wang Sheng-Hui <[email protected]>
---
fs/ext4/move_extent.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index c5826c6..8383257 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -1002,7 +1002,6 @@ mext_check_arguments(struct inode *orig_inode,
}

if ((orig_start >= EXT_MAX_BLOCKS) ||
- (donor_start >= EXT_MAX_BLOCKS) ||
(*len > EXT_MAX_BLOCKS) ||
(orig_start + *len >= EXT_MAX_BLOCKS)) {
ext4_debug("ext4 move extent: Can't handle over [%u] blocks "
--
1.7.1

2012-09-27 12:03:33

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove redundant offset check in move_extents.c/mext_check_arguments

On Mon, Jul 23, 2012 at 04:03:14PM +0800, Wang Sheng-Hui wrote:
> In the check code above, if orig_start != donor_start, we would
> return -EINVAL. So here, orig_start should be equal with donor_start.
> Remove the redundant check here.
>
> Signed-off-by: Wang Sheng-Hui <[email protected]>

Applied, thanks. (And apologies for the delay in getting back to
you!)

- Ted