2012-12-04 09:29:00

by Jiri Slaby

Subject: next: ext4 build failure

Hi,

commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa
Author: Tao Ma <[email protected]>
Date: Sun Dec 2 20:30:52 2012 -0500

ext4: let fallocate handle inline data correctly

added

static int int ext4_convert_inline_data(struct inode *inode)

^^^^^^^

when EXT4_FS_XATTR is unset.

Care to fix that?

thanks,
--
js
suse labs

2012-12-04 13:27:09

by Theodore Ts'o

Subject: Re: next: ext4 build failure

On Tue, Dec 04, 2012 at 10:29:00AM +0100, Jiri Slaby wrote:
> Hi,
>
> commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa
> Author: Tao Ma <[email protected]>
> Date: Sun Dec 2 20:30:52 2012 -0500
>
> ext4: let fallocate handle inline data correctly
>
> added
>
> static int int ext4_convert_inline_data(struct inode *inode)
>
> ^^^^^^^
>
> when EXT4_FS_XATTR is unset.
>
> Care to fix that?

Oops. Thanks for catching this!!!

- Ted

2012-12-04 13:29:45

by Jiri Slaby

Subject: Re: next: ext4 build failure

On 12/04/2012 02:27 PM, Theodore Ts'o wrote:
> On Tue, Dec 04, 2012 at 10:29:00AM +0100, Jiri Slaby wrote:
>> Hi,
>>
>> commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa
>> Author: Tao Ma <[email protected]>
>> Date: Sun Dec 2 20:30:52 2012 -0500
>>
>> ext4: let fallocate handle inline data correctly
>>
>> added
>>
>> static int int ext4_convert_inline_data(struct inode *inode)
>>
>> ^^^^^^^
>>
>> when EXT4_FS_XATTR is unset.
>>
>> Care to fix that?
>
> Oops. Thanks for catching this!!!

This is not the only one BTW, see:
http://decibel.fi.muni.cz/gitweb/?p=linux.git;a=commitdiff;h=1a166497fe3d76e5af8af02e2ee5a967b2829b93

thanks,
--
js
suse labs

2012-12-04 13:40:23

by Tao Ma

Subject: Re: next: ext4 build failure

Hi Ted,
On 12/04/2012 09:27 PM, Theodore Ts'o wrote:
> On Tue, Dec 04, 2012 at 10:29:00AM +0100, Jiri Slaby wrote:
>> Hi,
>>
>> commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa
>> Author: Tao Ma <[email protected]>
>> Date: Sun Dec 2 20:30:52 2012 -0500
>>
>> ext4: let fallocate handle inline data correctly
>>
>> added
>>
>> static int int ext4_convert_inline_data(struct inode *inode)
>>
>> ^^^^^^^
>>
>> when EXT4_FS_XATTR is unset.
>>
>> Care to fix that?
>
> Oops. Thanks for catching this!!!
Please push the patch with the subject "[PATCH] ext4: Fix inline data
build warning found by kernel build testing." and these error should go
away. And also Dan's smatch has found another issue and I have sent out
the patch with subject "[PATCH] ext4: Fix inline data build warning
found by kernel build testing.".

Thanks
Tao
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

2012-12-04 13:42:20

by Tao Ma

Subject: Re: next: ext4 build failure

On 12/04/2012 09:40 PM, Tao Ma wrote:
> Hi Ted,
> On 12/04/2012 09:27 PM, Theodore Ts'o wrote:
>> On Tue, Dec 04, 2012 at 10:29:00AM +0100, Jiri Slaby wrote:
>>> Hi,
>>>
>>> commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa
>>> Author: Tao Ma <[email protected]>
>>> Date: Sun Dec 2 20:30:52 2012 -0500
>>>
>>> ext4: let fallocate handle inline data correctly
>>>
>>> added
>>>
>>> static int int ext4_convert_inline_data(struct inode *inode)
>>>
>>> ^^^^^^^
>>>
>>> when EXT4_FS_XATTR is unset.
>>>
>>> Care to fix that?
>>
>> Oops. Thanks for catching this!!!
> Please push the patch with the subject "[PATCH] ext4: Fix inline data
> build warning found by kernel build testing." and these error should go
> away. And also Dan's smatch has found another issue and I have sent out
> the patch with subject "[PATCH] ext4: Fix inline data build warning
> found by kernel build testing.".
sorry, I hit the send button too fast. The subject for the 2nd patch is
"[PATCH] ext4: Fix a build warning in __ext4_journalled_writepage."
Sorry for all the trouble.

Thanks
Tao

2012-12-04 13:12:18

by Tao Ma

Subject: Re: next: ext4 build failure

Hi Jiri,

Thanks for the report.

The corresponding fix is already sent to Ted in the patch named "ext4:
Fix inline data build warning found by kernel build testing.", but it
seems that Ted hasn't pushed it into ext4dev yet.

Thanks
Tao

On 12/04/2012 05:29 PM, Jiri Slaby wrote:
> Hi,
>
> commit a7b0168d4a9bb78535827ddaf9c055963f5bd7aa
> Author: Tao Ma <[email protected]>
> Date: Sun Dec 2 20:30:52 2012 -0500
>
> ext4: let fallocate handle inline data correctly
>
> added
>
> static int int ext4_convert_inline_data(struct inode *inode)
>
> ^^^^^^^
>
> when EXT4_FS_XATTR is unset.
>
> Care to fix that?
>
> thanks,
>