2016-05-28 21:36:55

by Bruce Dubbs

[permalink] [raw]
Subject: e2fsprogs-1.43 make check failures

When building e2fsprogs we normally ask users to run 'make check'. For
e2fsprogs-1.42.13 we had '153 tests succeeded, 0 tests failed', but for
version 1.43, we have '62 tests succeeded, 265 tests failed'.

Many of the failures look like:

$ cat f_lpffile.failed
--- ../../tests/f_lpffile/expect.1 2009-08-13 01:39:58.000000000 +0000
+++ f_lpffile.1.log 2016-05-28 19:40:20.364025801 +0000
@@ -1,3 +1,4 @@
+e2fsck 1.43 (17-May-2016)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity
--- ../../tests/f_lpffile/expect.2 2009-08-13 01:39:58.000000000 +0000
+++ f_lpffile.2.log 2016-05-28 19:40:20.367025703 +0000
@@ -1,3 +1,4 @@
+e2fsck 1.43 (17-May-2016)
Pass 1: Checking inodes, blocks, and sizes
Pass 2: Checking directory structure
Pass 3: Checking directory connectivity

In fact running:

[ /sources/e2fsprogs-1.43/build/tests ]$ grep ^+ *.failed|grep -v
1.43|grep -v @@|grep -v +++

gives no output. My conclusion is that all the tests actually pass, but
the expected results need to be updated in the release tarball.

-- Bruce Dubbs
linuxfromscratch.org


2016-05-28 22:45:37

by Xose Vazquez Perez

[permalink] [raw]
Subject: Re: e2fsprogs-1.43 make check failures

Bruce Dubbs wrote:

> When building e2fsprogs we normally ask users to run 'make check'. For
> e2fsprogs-1.42.13 we had '153 tests succeeded, 0 tests failed', but for
> version 1.43, we have '62 tests succeeded, 265 tests failed'.

Documented in: http://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.43

----
E2fsprogs 1.43 (May 17, 2016)

KNOWN BUG: "make check" will have many spurious failures in the tests directory.
The fix can be found at: https://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?id=e7d848266a224cc1ed3c74c6746b5c779a5f55ce
----

2016-05-28 23:54:22

by Bruce Dubbs

[permalink] [raw]
Subject: Re: e2fsprogs-1.43 make check failures

Xose Vazquez Perez wrote:
> Bruce Dubbs wrote:
>
>> When building e2fsprogs we normally ask users to run 'make check'. For
>> e2fsprogs-1.42.13 we had '153 tests succeeded, 0 tests failed', but for
>> version 1.43, we have '62 tests succeeded, 265 tests failed'.
>
> Documented in: http://e2fsprogs.sourceforge.net/e2fsprogs-release.html#1.43
>
> ----
> E2fsprogs 1.43 (May 17, 2016)
>
> KNOWN BUG: "make check" will have many spurious failures in the tests directory.
> The fix can be found at: https://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?id=e7d848266a224cc1ed3c74c6746b5c779a5f55ce
> ----

Missed that entry. Thank you.

-- Bruce