2013-06-06 13:31:56

by Jeff Liu

Subject: [PATCH] ext4: return FIEMAP_EXTENT_UNKNOWN if an extent is delayed allocations

From: Jie Liu <[email protected]>

Return the FIEMAP_EXTENT_UNKNOWN flag as well except the
FIEMAP_EXTENT_DELALLOC because the data location of an
delayed allocation extent is unknown.

Signed-off-by: Jie Liu <[email protected]>
---
fs/ext4/extents.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index bc0f191..47e17b1 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2125,7 +2125,8 @@ static int ext4_fill_fiemap_extents(struct inode *inode,
next_del = ext4_find_delayed_extent(inode, &es);
if (!exists && next_del) {
exists = 1;
- flags |= FIEMAP_EXTENT_DELALLOC;
+ flags |= (FIEMAP_EXTENT_DELALLOC |
+ FIEMAP_EXTENT_UNKNOWN);
}
up_read(&EXT4_I(inode)->i_data_sem);

--
1.7.9.5

2013-06-07 11:36:21

by Zheng Liu

Subject: Re: [PATCH] ext4: return FIEMAP_EXTENT_UNKNOWN if an extent is delayed allocations

On Thu, Jun 06, 2013 at 09:31:49PM +0800, Jeff Liu wrote:
> From: Jie Liu <[email protected]>
>
> Return the FIEMAP_EXTENT_UNKNOWN flag as well except the
> FIEMAP_EXTENT_DELALLOC because the data location of an
> delayed allocation extent is unknown.
>
> Signed-off-by: Jie Liu <[email protected]>

Reviewed-by: Zheng Liu <[email protected]>

- Zheng

> ---
> fs/ext4/extents.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index bc0f191..47e17b1 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2125,7 +2125,8 @@ static int ext4_fill_fiemap_extents(struct inode *inode,
> next_del = ext4_find_delayed_extent(inode, &es);
> if (!exists && next_del) {
> exists = 1;
> - flags |= FIEMAP_EXTENT_DELALLOC;
> + flags |= (FIEMAP_EXTENT_DELALLOC |
> + FIEMAP_EXTENT_UNKNOWN);
> }
> up_read(&EXT4_I(inode)->i_data_sem);
>
> --
> 1.7.9.5
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2013-06-18 15:08:24

by Theodore Ts'o

Subject: Re: [PATCH] ext4: return FIEMAP_EXTENT_UNKNOWN if an extent is delayed allocations

On Fri, Jun 07, 2013 at 07:54:22PM +0800, Zheng Liu wrote:
> On Thu, Jun 06, 2013 at 09:31:49PM +0800, Jeff Liu wrote:
> > From: Jie Liu <[email protected]>
> >
> > Return the FIEMAP_EXTENT_UNKNOWN flag as well except the
> > FIEMAP_EXTENT_DELALLOC because the data location of an
> > delayed allocation extent is unknown.
> >
> > Signed-off-by: Jie Liu <[email protected]>
>
> Reviewed-by: Zheng Liu <[email protected]>

Thanks, applied.

- Ted