2013-06-26 19:31:56

by Eric Sandeen

Subject: [PATCH] e2fsprogs: fix tests/f_extent_oobounds

tests/f_extent_oobounds runs debugfs from the system, not
from the source tree, and if the system's debugfs doesn't
have the extent_open command it fails silently.

Use $DEBUGFS to get the right executable.

Signed-off-by: Eric Sandeen <[email protected]>
---

diff --git a/tests/f_extent_oobounds/script b/tests/f_extent_oobounds/script
index 31ac6c9..b1f0e1a 100644
--- a/tests/f_extent_oobounds/script
+++ b/tests/f_extent_oobounds/script
@@ -5,7 +5,7 @@ TEST_DATA="$test_name.tmp"

dd if=/dev/zero of=$TMPFILE bs=1k count=256 > /dev/null 2>&1
mke2fs -Ft ext4 $TMPFILE > /dev/null 2>&1
-debugfs -w $TMPFILE << EOF > /dev/null 2>&1
+$DEBUGFS -w $TMPFILE << EOF > /dev/null 2>&1
write /dev/null testfile
extent_open testfile
insert_node 0 15 100

2013-06-26 23:09:23

by Eric Sandeen

Subject: [PATCH V2] e2fsprogs: fix tests/f_extent_oobounds

Use $DEBUGFS and $MKE2FS to get the in-tree executables
for this test.

(Build machines which run make check shouldn't need to have
e2fsprogs installed, and we should be testing just-built versions
of the tools anyway)

Signed-off-by: Eric Sandeen <[email protected]>
---

V2: need to fix mke2fs as well as debugfs

diff --git a/tests/f_extent_oobounds/script b/tests/f_extent_oobounds/script
index 31ac6c9..b00b031 100644
--- a/tests/f_extent_oobounds/script
+++ b/tests/f_extent_oobounds/script
@@ -4,8 +4,8 @@ SKIP_GUNZIP="true"
TEST_DATA="$test_name.tmp"

dd if=/dev/zero of=$TMPFILE bs=1k count=256 > /dev/null 2>&1
-mke2fs -Ft ext4 $TMPFILE > /dev/null 2>&1
-debugfs -w $TMPFILE << EOF > /dev/null 2>&1
+$MKE2FS -Ft ext4 $TMPFILE > /dev/null 2>&1
+$DEBUGFS -w $TMPFILE << EOF > /dev/null 2>&1
write /dev/null testfile
extent_open testfile
insert_node 0 15 100