I was looking through the RHEL e2fsprogs.spec file and saw that you are
still
carrying the e2fsprogs-1.40.4-sb_feature_check_ignore.patch to avoid
problems
if the kernel sets xattrs on a new filesystem and doesn't copy this into
the
backup superblock.
It seems that mke2fs enables the xattr feature in the superblock by default
for all filesystems (courtesy of misc/default_profile.c), and e2fsck
doesn't
drop COMPAT_EXT_XATTR even if the filesystem doesn't have xattrs, so most
of
the danger of not having this patch are behind us.
That said, it probably still makes sense to include this patch into the
upstream e2fsprogs, unless there is some reason not to? It looks pretty
low risk.
Cheers, Andreas
--
Andreas Dilger
Lustre Software Architect
Intel High Performance Data Division
On 7/18/14, 2:50 PM, Dilger, Andreas wrote:
> I was looking through the RHEL e2fsprogs.spec file and saw that you are
> still
> carrying the e2fsprogs-1.40.4-sb_feature_check_ignore.patch to avoid
> problems
> if the kernel sets xattrs on a new filesystem and doesn't copy this into
> the
> backup superblock.
Ugh, yeah, that's just been there forever, TBH, I forgot about it.
I'll actually have to refamiliarize myself with why it showed up years
ago! :)
> It seems that mke2fs enables the xattr feature in the superblock by default
> for all filesystems (courtesy of misc/default_profile.c), and e2fsck
> doesn't
> drop COMPAT_EXT_XATTR even if the filesystem doesn't have xattrs, so most
> of
> the danger of not having this patch are behind us.
>
> That said, it probably still makes sense to include this patch into the
> upstream e2fsprogs, unless there is some reason not to? It looks pretty
> low risk.
Well, ISTR at the time I added it, it was a hacky workaround, rather than
a proper fix. I'll have to look at it again.
-eric
> Cheers, Andreas
>