2022-02-01 20:43:12

by Ritesh Harjani

Subject: [RFC 3/6] ext4: Use in_range() for range checking in ext4_fc_replay_check_excluded

Instead of open coding it, use in_range() function instead.

Signed-off-by: Ritesh Harjani <[email protected]>
---
fs/ext4/fast_commit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 5934c23e153e..bd6a47d18716 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -1874,8 +1874,8 @@ bool ext4_fc_replay_check_excluded(struct super_block *sb, ext4_fsblk_t blk)
if (state->fc_regions[i].ino == 0 ||
state->fc_regions[i].len == 0)
continue;
- if (blk >= state->fc_regions[i].pblk &&
- blk < state->fc_regions[i].pblk + state->fc_regions[i].len)
+ if (in_range(blk, state->fc_regions[i].pblk,
+ state->fc_regions[i].len))
return true;
}
return false;
--
2.31.1

2022-02-02 20:35:50

by Jan Kara

Subject: Re: [RFC 3/6] ext4: Use in_range() for range checking in ext4_fc_replay_check_excluded

On Mon 31-01-22 20:46:52, Ritesh Harjani wrote:
> Instead of open coding it, use in_range() function instead.
>
> Signed-off-by: Ritesh Harjani <[email protected]>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <[email protected]>

Honza

> ---
> fs/ext4/fast_commit.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index 5934c23e153e..bd6a47d18716 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -1874,8 +1874,8 @@ bool ext4_fc_replay_check_excluded(struct super_block *sb, ext4_fsblk_t blk)
> if (state->fc_regions[i].ino == 0 ||
> state->fc_regions[i].len == 0)
> continue;
> - if (blk >= state->fc_regions[i].pblk &&
> - blk < state->fc_regions[i].pblk + state->fc_regions[i].len)
> + if (in_range(blk, state->fc_regions[i].pblk,
> + state->fc_regions[i].len))
> return true;
> }
> return false;
> --
> 2.31.1
>
--
Jan Kara <[email protected]>
SUSE Labs, CR