2015-02-03 09:22:37

by Olaf Hering

Subject: [PATCH] ext3: dump dentry in ext3_dx_add_entry

Signed-off-by: Olaf Hering <[email protected]>
Cc: Jan Kara <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Andreas Dilger <[email protected]>
---
fs/ext3/namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
index f197736..0692058 100644
--- a/fs/ext3/namei.c
+++ b/fs/ext3/namei.c
@@ -1529,7 +1529,7 @@ static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry,
if (levels && (dx_get_count(frames->entries) ==
dx_get_limit(frames->entries))) {
ext3_warning(sb, __func__,
- "Directory index full!");
+ "Directory index full! %pd4 %pd", dentry->d_parent, dentry);
err = -ENOSPC;
goto cleanup;
}

2015-02-03 10:39:39

by Bernd Schubert

Subject: Re: [PATCH] ext3: dump dentry in ext3_dx_add_entry

On 02/03/2015 10:22 AM, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <[email protected]>
> Cc: Jan Kara <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: Andreas Dilger <[email protected]>
> ---
> fs/ext3/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> index f197736..0692058 100644
> --- a/fs/ext3/namei.c
> +++ b/fs/ext3/namei.c
> @@ -1529,7 +1529,7 @@ static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry,
> if (levels && (dx_get_count(frames->entries) ==
> dx_get_limit(frames->entries))) {
> ext3_warning(sb, __func__,
> - "Directory index full!");
> + "Directory index full! %pd4 %pd", dentry->d_parent, dentry);
> err = -ENOSPC;
> goto cleanup;
> }

Would you mind to also add the inode number? That way one could use
debugfs to figure out the complete path.
And it should be done for ext4 as well.



Cheers,
Bernd