2015-04-20 17:59:13

by Eric Sandeen

Subject: [PATCH] e2fsprogs: use $DUMPE2FS in resize_test script

Use $DUMPE2FS in resize tests to be sure it's testing
the in-tree dumpe2fs, not the system dumpe2fs (which may
not even be there...)

Signed-off-by: Eric Sandeen <[email protected]>
---

(somehow I thought I had sent this, or something similar, before ...
can't find it, oh well!)

diff --git a/tests/scripts/resize_test b/tests/scripts/resize_test
index 0633e0c..dfd45ac 100755
--- a/tests/scripts/resize_test
+++ b/tests/scripts/resize_test
@@ -67,7 +67,7 @@ fi
echo $FSCK -fy $TMPFILE >> $LOG 2>&1
if ! $FSCK -fy $TMPFILE >> $LOG 2>&1
then
- dumpe2fs $TMPFILE >> $LOG
+ $DUMPE2FS $TMPFILE >> $LOG
return 1
fi

@@ -97,7 +97,7 @@ fi
echo $FSCK -fy $TMPFILE >> $LOG 2>&1
if ! $FSCK -fy $TMPFILE >> $LOG 2>&1
then
- dumpe2fs $TMPFILE >> $LOG
+ $DUMPE2FS $TMPFILE >> $LOG
return 1
fi

@@ -122,7 +122,7 @@ fi
echo $FSCK -fy $TMPFILE >> $LOG 2>&1
if ! $FSCK -fy $TMPFILE >> $LOG 2>&1
then
- dumpe2fs $TMPFILE >> $LOG
+ $DUMPE2FS $TMPFILE >> $LOG
return 1
fi

@@ -147,7 +147,7 @@ fi
echo $FSCK -fy $TMPFILE >> $LOG 2>&1
if ! $FSCK -fy $TMPFILE >> $LOG 2>&1
then
- dumpe2fs $TMPFILE >> $LOG
+ $DUMPE2FS $TMPFILE >> $LOG
return 1
fi

2015-05-23 22:40:14

by Theodore Ts'o

Subject: Re: [PATCH] e2fsprogs: use $DUMPE2FS in resize_test script

On Mon, Apr 20, 2015 at 12:59:11PM -0500, Eric Sandeen wrote:
> Use $DUMPE2FS in resize tests to be sure it's testing
> the in-tree dumpe2fs, not the system dumpe2fs (which may
> not even be there...)
>
> Signed-off-by: Eric Sandeen <[email protected]>

Applied, thanks

- Ted