2016-04-15 03:20:48

by Eric Sandeen

Subject: [PATCH] e2image: don't leak progress info to stdout

Commit c8ee0d60 fixed most of these, but missed this one.

# e2image -r -p <device> - > imagefile

leads to a corrupted image due to the "Scanning inodes..."
printf going to stdout.

Reported-by: Alex Markley <[email protected]>
Addresses-Red-Hat-Bugzilla: #1327329
Signed-off-by: Eric Sandeen <[email protected]>

diff --git a/misc/e2image.c b/misc/e2image.c
index e9b4ae2..690ad2c 100644
--- a/misc/e2image.c
+++ b/misc/e2image.c
@@ -1285,7 +1285,7 @@ static void write_raw_image_file(ext2_filsys fs, int fd, int type, int flags)

mark_table_blocks(fs);
if (show_progress)
- printf("%s", _("Scanning inodes...\n"));
+ fprintf(stderr, "%s", _("Scanning inodes...\n"));

retval = ext2fs_open_inode_scan(fs, 0, &scan);
if (retval) {

2016-04-15 15:11:27

by Theodore Ts'o

Subject: Re: [PATCH] e2image: don't leak progress info to stdout

On Thu, Apr 14, 2016 at 10:20:46PM -0500, Eric Sandeen wrote:
> Commit c8ee0d60 fixed most of these, but missed this one.
>
> # e2image -r -p <device> - > imagefile
>
> leads to a corrupted image due to the "Scanning inodes..."
> printf going to stdout.
>
> Reported-by: Alex Markley <[email protected]>
> Addresses-Red-Hat-Bugzilla: #1327329
> Signed-off-by: Eric Sandeen <[email protected]>

Applied, thanks.

- Ted