2018-01-09 12:38:21

by piaojun

Subject: [PATCH] ext4: no need flush workqueue before destroying it

destroy_workqueue() will do flushing work for us.

Signed-off-by: Jun Piao <[email protected]>
---
fs/ext4/super.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0556cd0..2f46b0b 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
ext4_unregister_li_request(sb);
ext4_quota_off_umount(sb);

- flush_workqueue(sbi->rsv_conversion_wq);
destroy_workqueue(sbi->rsv_conversion_wq);

if (sbi->s_journal) {
--

2018-01-09 15:07:17

by Jan Kara

Subject: Re: [PATCH] ext4: no need flush workqueue before destroying it

On Tue 09-01-18 20:37:54, piaojun wrote:
> destroy_workqueue() will do flushing work for us.
>
> Signed-off-by: Jun Piao <[email protected]>

Looks good. You can add:

Reviewed-by: Jan Kara <[email protected]>

Adding Ted to CC as a maintainer...

Honza

> ---
> fs/ext4/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0556cd0..2f46b0b 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
> ext4_unregister_li_request(sb);
> ext4_quota_off_umount(sb);
>
> - flush_workqueue(sbi->rsv_conversion_wq);
> destroy_workqueue(sbi->rsv_conversion_wq);
>
> if (sbi->s_journal) {
> --
--
Jan Kara <[email protected]>
SUSE Labs, CR

2018-01-10 00:17:04

by piaojun

Subject: Re: [PATCH] ext4: no need flush workqueue before destroying it

Hi Jan,

Thanks for reviewing, and I will resend this patch again.

thanks,
Jun

On 2018/1/9 23:07, Jan Kara wrote:
> On Tue 09-01-18 20:37:54, piaojun wrote:
>> destroy_workqueue() will do flushing work for us.
>>
>> Signed-off-by: Jun Piao <[email protected]>
>
> Looks good. You can add:
>
> Reviewed-by: Jan Kara <[email protected]>
>
> Adding Ted to CC as a maintainer...
>
> Honza
>
>> ---
>> fs/ext4/super.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
>> index 0556cd0..2f46b0b 100644
>> --- a/fs/ext4/super.c
>> +++ b/fs/ext4/super.c
>> @@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
>> ext4_unregister_li_request(sb);
>> ext4_quota_off_umount(sb);
>>
>> - flush_workqueue(sbi->rsv_conversion_wq);
>> destroy_workqueue(sbi->rsv_conversion_wq);
>>
>> if (sbi->s_journal) {
>> --

2018-01-10 02:42:37

by Theodore Ts'o

Subject: Re: [PATCH] ext4: no need flush workqueue before destroying it

On Wed, Jan 10, 2018 at 08:16:47AM +0800, piaojun wrote:
>
> On 2018/1/9 23:07, Jan Kara wrote:
> > On Tue 09-01-18 20:37:54, piaojun wrote:
> >> destroy_workqueue() will do flushing work for us.
> >>
> >> Signed-off-by: Jun Piao <[email protected]>
> >
> > Looks good. You can add:
> >
> > Reviewed-by: Jan Kara <[email protected]>

Thanks, applied. (Note, you don't have resend the patch after it's
been reviewed; I can append the Reviewed-by line.)

- Ted