2012-01-04 07:19:49

by Yongqiang Yang

Subject: [PATCH] mke2fs: correct help text for option -G of mke2fs

The option '-G' is used to pass number of groups in a flex_bg, the
previous help text - 'meta-group-size' - could confuse users with
meta_bg.

Signed-off-by: Yongqiang Yang <[email protected]>
---
misc/mke2fs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 0ef2531..52746fe 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -116,7 +116,7 @@ static void usage(void)
fprintf(stderr, _("Usage: %s [-c|-l filename] [-b block-size] "
"[-C cluster-size]\n\t[-i bytes-per-inode] [-I inode-size] "
"[-J journal-options]\n"
- "\t[-G meta group size] [-N number-of-inodes]\n"
+ "\t[-G number-of-groups-per-flex_bg] [-N number-of-inodes]\n"
"\t[-m reserved-blocks-percentage] [-o creator-os]\n"
"\t[-g blocks-per-group] [-L volume-label] "
"[-M last-mounted-directory]\n\t[-O feature[,...]] "
--
1.7.5.1

2012-01-04 07:22:48

by Andreas Dilger

Subject: Re: [PATCH] mke2fs: correct help text for option -G of mke2fs

Probably "flex_group_size" or "flex_group_factor" is as clear and a lot shorter.

Cheers, Andreas

On 2012-01-03, at 20:29, Yongqiang Yang <[email protected]> wrote:

> The option '-G' is used to pass number of groups in a flex_bg, the
> previous help text - 'meta-group-size' - could confuse users with
> meta_bg.
>
> Signed-off-by: Yongqiang Yang <[email protected]>
> ---
> misc/mke2fs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 0ef2531..52746fe 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -116,7 +116,7 @@ static void usage(void)
> fprintf(stderr, _("Usage: %s [-c|-l filename] [-b block-size] "
> "[-C cluster-size]\n\t[-i bytes-per-inode] [-I inode-size] "
> "[-J journal-options]\n"
> - "\t[-G meta group size] [-N number-of-inodes]\n"
> + "\t[-G number-of-groups-per-flex_bg] [-N number-of-inodes]\n"
> "\t[-m reserved-blocks-percentage] [-o creator-os]\n"
> "\t[-g blocks-per-group] [-L volume-label] "
> "[-M last-mounted-directory]\n\t[-O feature[,...]] "
> --
> 1.7.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2012-01-04 07:47:31

by Yongqiang Yang

Subject: Re: [PATCH] mke2fs: correct help text for option -G of mke2fs

On Wed, Jan 4, 2012 at 3:22 PM, Andreas Dilger <[email protected]> wrote:
> Probably "flex_group_size" or "flex_group_factor" is as clear and a lot shorter.
I will resend a patch using flex_group_factor.

Thanks,
Yongqiang.
>
> Cheers, Andreas
>
> On 2012-01-03, at 20:29, Yongqiang Yang <[email protected]> wrote:
>
>> The option '-G' is used to pass number of groups in a flex_bg, the
>> previous help text - 'meta-group-size' - could confuse users with
>> meta_bg.
>>
>> Signed-off-by: Yongqiang Yang <[email protected]>
>> ---
>> misc/mke2fs.c | ? ?2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
>> index 0ef2531..52746fe 100644
>> --- a/misc/mke2fs.c
>> +++ b/misc/mke2fs.c
>> @@ -116,7 +116,7 @@ static void usage(void)
>> ? ?fprintf(stderr, _("Usage: %s [-c|-l filename] [-b block-size] "
>> ? ?"[-C cluster-size]\n\t[-i bytes-per-inode] [-I inode-size] "
>> ? ?"[-J journal-options]\n"
>> - ? ?"\t[-G meta group size] [-N number-of-inodes]\n"
>> + ? ?"\t[-G number-of-groups-per-flex_bg] [-N number-of-inodes]\n"
>> ? ?"\t[-m reserved-blocks-percentage] [-o creator-os]\n"
>> ? ?"\t[-g blocks-per-group] [-L volume-label] "
>> ? ?"[-M last-mounted-directory]\n\t[-O feature[,...]] "
>> --
>> 1.7.5.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to [email protected]
>> More majordomo info at ?http://vger.kernel.org/majordomo-info.html



--
Best Wishes
Yongqiang Yang