2019-04-22 21:08:57

by Eric Biggers

[permalink] [raw]
Subject: [PATCH] libext2fs: remove unused variable 'buff'

From: Eric Biggers <[email protected]>

In ext2fs_dirhash2(), the outer 'buff' variable is never used.

Cc: Gabriel Krisman Bertazi <[email protected]>
Signed-off-by: Eric Biggers <[email protected]>
---
lib/ext2fs/dirhash.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/lib/ext2fs/dirhash.c b/lib/ext2fs/dirhash.c
index f1e7734d..97fd2431 100644
--- a/lib/ext2fs/dirhash.c
+++ b/lib/ext2fs/dirhash.c
@@ -279,7 +279,6 @@ errcode_t ext2fs_dirhash2(int version, const char *name, int len,
{
errcode_t r;
int dlen;
- unsigned char *buff;

if (len && charset) {
char buff[PATH_MAX];
--
2.21.0.593.g511ec345e18-goog



2019-04-23 04:06:41

by Gabriel Krisman Bertazi

[permalink] [raw]
Subject: Re: [PATCH] libext2fs: remove unused variable 'buff'

Eric Biggers <[email protected]> writes:

> From: Eric Biggers <[email protected]>
>
> In ext2fs_dirhash2(), the outer 'buff' variable is never used.
>
> Cc: Gabriel Krisman Bertazi <[email protected]>
> Signed-off-by: Eric Biggers <[email protected]>

Reviewed-by: Gabriel Krisman Bertazi <[email protected]>


--
Gabriel Krisman Bertazi