2008-05-31 18:15:56

by Manish Katiyar

Subject: [PATCH] ext2 : correct comments in fs/ext2/balloc.c

This patch corrects the wrong function name mentioned in the comments
of ext2_free_blocks() function

========================================================

Signed-off-by: Manish Katiyar <[email protected]>

--- a/fs/ext2/balloc.c 2008-05-11 23:54:40.000000000 +0530
+++ b/fs/ext2/balloc.c 2008-05-31 23:44:20.000000000 +0530
@@ -478,7 +478,7 @@
}

/**
- * ext2_free_blocks_sb() -- Free given blocks and update quota and i_blocks
+ * ext2_free_blocks() -- Free given blocks and update quota and i_blocks
* @inode: inode
* @block: start physcial block to free
* @count: number of blocks to free


==========================================================

--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************

2008-06-03 12:16:56

by Mark Asselstine

Subject: Re: [PATCH] ext2 : correct comments in fs/ext2/balloc.c

On Sat, May 31, 2008 at 2:15 PM, Manish Katiyar <[email protected]> wrote:
> This patch corrects the wrong function name mentioned in the comments
> of ext2_free_blocks() function
>
> ========================================================
>
> Signed-off-by: Manish Katiyar <[email protected]>
Reviewed-by: Mark Asselstine <[email protected]>

One comment, lose the timestamps they add no value.
>
> --- a/fs/ext2/balloc.c 2008-05-11 23:54:40.000000000 +0530
> +++ b/fs/ext2/balloc.c 2008-05-31 23:44:20.000000000 +0530
> @@ -478,7 +478,7 @@
> }
>
> /**
> - * ext2_free_blocks_sb() -- Free given blocks and update quota and i_blocks
> + * ext2_free_blocks() -- Free given blocks and update quota and i_blocks
> * @inode: inode
> * @block: start physcial block to free
> * @count: number of blocks to free
>
>
> ==========================================================
>
> --
> Thanks & Regards,
> ********************************************
> Manish Katiyar ( http://mkatiyar.googlepages.com )
> 3rd Floor, Fair Winds Block
> EGL Software Park
> Off Intermediate Ring Road
> Bangalore 560071, India
> ***********************************************
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

2008-06-03 12:19:07

by Manish Katiyar

Subject: Re: [PATCH] ext2 : correct comments in fs/ext2/balloc.c

On Tue, Jun 3, 2008 at 5:46 PM, Mark Asselstine <[email protected]> wrote:
> On Sat, May 31, 2008 at 2:15 PM, Manish Katiyar <[email protected]> wrote:
>> This patch corrects the wrong function name mentioned in the comments
>> of ext2_free_blocks() function
>>
>> ========================================================
>>
>> Signed-off-by: Manish Katiyar <[email protected]>
> Reviewed-by: Mark Asselstine <[email protected]>
>
> One comment, lose the timestamps they add no value.

OK Mark,... Will resend the patch with timestamp removed.

Thanks -
Manish


>>
>> --- a/fs/ext2/balloc.c 2008-05-11 23:54:40.000000000 +0530
>> +++ b/fs/ext2/balloc.c 2008-05-31 23:44:20.000000000 +0530
>> @@ -478,7 +478,7 @@
>> }
>>
>> /**
>> - * ext2_free_blocks_sb() -- Free given blocks and update quota and i_blocks
>> + * ext2_free_blocks() -- Free given blocks and update quota and i_blocks
>> * @inode: inode
>> * @block: start physcial block to free
>> * @count: number of blocks to free
>>
>>
>> ==========================================================
>>
>> --
>> Thanks & Regards,
>> ********************************************
>> Manish Katiyar ( http://mkatiyar.googlepages.com )
>> 3rd Floor, Fair Winds Block
>> EGL Software Park
>> Off Intermediate Ring Road
>> Bangalore 560071, India
>> ***********************************************
>> --
>> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>



--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************