2010-11-17 00:40:52

by Janakiram Sistla

Subject: Re: [PATCH] fs : ext4 : super.c fixed coding style violations fs/ext4/super.c:41: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> fs/ext4/super.c:546: ERROR: "foo * bar" should be "foo *bar" fs/ext4/super.c:546: WARNING: space proh

On Tue, Nov 16, 2010 at 4:41 PM, Vamsi Krishna B
<[email protected]> wrote:
> Signed-off-by: Vamsi Krishna B <[email protected]>
> ---
> ?fs/ext4/super.c | ? ?6 +++---
> ?1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 61182fe..11a46dc 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -38,7 +38,7 @@
> ?#include <linux/ctype.h>
> ?#include <linux/log2.h>
> ?#include <linux/crc16.h>
> -#include <asm/uaccess.h>
> +#include <linux/uaccess.h>
>
> ?#include <linux/kthread.h>
> ?#include <linux/freezer.h>
> @@ -543,7 +543,7 @@ void __ext4_abort(struct super_block *sb, const char *function,
> ? ? ? ? ? ? ? ?panic("EXT4-fs panic from previous error\n");
> ?}
>
> -void ext4_msg (struct super_block * sb, const char *prefix,
> +void ext4_msg(struct super_block *sb, const char *prefix,
> ? ? ? ? ? ? ? ? ? const char *fmt, ...)
> ?{
> ? ? ? ?va_list args;
> @@ -1138,7 +1138,7 @@ static int bdev_try_to_free_page(struct super_block *sb, struct page *page,
>
> ?#ifdef CONFIG_QUOTA
> ?#define QTYPE2NAME(t) ((t) == USRQUOTA ? "user" : "group")
> -#define QTYPE2MOPT(on, t) ((t) == USRQUOTA?((on)##USRJQUOTA):((on)##GRPJQUOTA))
> +#define QTYPE2MOPT(on, t) ((t) == USRQUOTA ? ((on)##USRJQUOTA) : ((on)##GRPJQUOTA))
>
> ?static int ext4_write_dquot(struct dquot *dquot);
> ?static int ext4_acquire_dquot(struct dquot *dquot);
> -

Vamsi,

Can you make the patch subject small ,very difficult to understand.

Regards,
Ram