2010-05-04 20:55:30

by Curt Wohlgemuth

Subject: [PATCH] ext4: Remove extraneous newlines in ext4_msg() calls

This removes extraneous newlines that are sent to ext4_msg().

Signed-off-by: Curt Wohlgemuth <[email protected]>
---

diff -uprN orig/fs/ext4/inode.c new/fs/ext4/inode.c
--- orig/fs/ext4/inode.c 2010-05-04 13:46:06.000000000 -0700
+++ new/fs/ext4/inode.c 2010-05-04 13:49:18.000000000 -0700
@@ -2282,7 +2282,7 @@ static int mpage_da_map_blocks(struct mp
ext4_msg(mpd->inode->i_sb, KERN_CRIT,
"delayed block allocation failed for inode %lu at "
"logical offset %llu with max blocks %zd with "
- "error %d\n", mpd->inode->i_ino,
+ "error %d", mpd->inode->i_ino,
(unsigned long long) next,
mpd->b_size >> mpd->inode->i_blkbits, err);
printk(KERN_CRIT "This should not happen!! "
@@ -2941,7 +2941,7 @@ retry:
if (IS_ERR(handle)) {
ret = PTR_ERR(handle);
ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: "
- "%ld pages, ino %lu; err %d\n", __func__,
+ "%ld pages, ino %lu; err %d", __func__,
wbc->nr_to_write, inode->i_ino, ret);
goto out_writepages;
}
@@ -3016,7 +3016,7 @@ retry:
if (pages_skipped != wbc->pages_skipped)
ext4_msg(inode->i_sb, KERN_CRIT,
"This should not happen leaving %s "
- "with nr_to_write = %ld ret = %d\n",
+ "with nr_to_write = %ld ret = %d",
__func__, wbc->nr_to_write, ret);

/* Update index */
diff -uprN orig/fs/ext4/super.c new/fs/ext4/super.c
--- orig/fs/ext4/super.c 2010-05-04 13:46:06.000000000 -0700
+++ new/fs/ext4/super.c 2010-05-04 13:49:18.000000000 -0700
@@ -3001,7 +3001,7 @@ no_journal:
err = ext4_setup_system_zone(sb);
if (err) {
ext4_msg(sb, KERN_ERR, "failed to initialize system "
- "zone (%d)\n", err);
+ "zone (%d)", err);
goto failed_mount4;
}

2010-05-21 01:05:37

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Remove extraneous newlines in ext4_msg() calls

On Tue, May 04, 2010 at 01:55:27PM -0700, Curt Wohlgemuth wrote:
> This removes extraneous newlines that are sent to ext4_msg().

Added to the ext4 patch queue.

- Ted