2011-08-31 17:46:47

by Theodore Ts'o

[permalink] [raw]
Subject: [GIT PULL] ext4 fixes for 3.1-rc5

Hi Linus,

Please pull from:

git://github.com/tytso/ext4.git for_linus-20110831 # 8c0bec2151a

to get the following bug fix. It address a lockdep warning which a lot
of people have been complaining about.

Thanks,

- Ted


Jiaying Zhang (1):
ext4: remove i_mutex lock in ext4_evict_inode to fix lockdep complaining

fs/ext4/ext4.h | 1 +
fs/ext4/inode.c | 3 ---
fs/ext4/page-io.c | 18 +++++++++++++++++-
3 files changed, 18 insertions(+), 4 deletions(-)


2011-08-31 18:26:54

by Linus Torvalds

[permalink] [raw]
Subject: Re: [GIT PULL] ext4 fixes for 3.1-rc5

On Wed, Aug 31, 2011 at 10:46 AM, Theodore Ts'o <[email protected]> wrote:
>
> Please pull from:
>
> ? ? ? ?git://github.com/tytso/ext4.git for_linus-20110831 # 8c0bec2151a
>
> to get the following bug fix. ?It address a lockdep warning which a lot
> of people have been complaining about.

So what's up? Bad English and a github address makes me unhappy.

I can imagine that you decided not to use kernel.org due to hera being
down, but this still makes me want to say "please more references".

Linus

2011-08-31 18:47:14

by Arnaud Lacombe

[permalink] [raw]
Subject: Re: [GIT PULL] ext4 fixes for 3.1-rc5

Hi,

On Wed, Aug 31, 2011 at 2:25 PM, Linus Torvalds
<[email protected]> wrote:
> On Wed, Aug 31, 2011 at 10:46 AM, Theodore Ts'o <[email protected]> wrote:
>>
>> Please pull from:
>>
>> ? ? ? ?git://github.com/tytso/ext4.git for_linus-20110831 # 8c0bec2151a
>>
>> to get the following bug fix. ?It address a lockdep warning which a lot
>> of people have been complaining about.
>
> So what's up? Bad English and a github address makes me unhappy.
>
> I can imagine that you decided not to use kernel.org due to hera being
> down, but this still makes me want to say "please more references".
>
shouldn't all pull request be digitally signed, by _default_ ?

- Arnaud

2011-08-31 18:57:07

by Arnaud Lacombe

[permalink] [raw]
Subject: Re: [GIT PULL] ext4 fixes for 3.1-rc5

Hi,

On Wed, Aug 31, 2011 at 2:47 PM, Arnaud Lacombe <[email protected]> wrote:
> Hi,
>
> On Wed, Aug 31, 2011 at 2:25 PM, Linus Torvalds
> <[email protected]> wrote:
>> On Wed, Aug 31, 2011 at 10:46 AM, Theodore Ts'o <[email protected]> wrote:
>>>
>>> Please pull from:
>>>
>>> ? ? ? ?git://github.com/tytso/ext4.git for_linus-20110831 # 8c0bec2151a
>>>
>>> to get the following bug fix. ?It address a lockdep warning which a lot
>>> of people have been complaining about.
>>
>> So what's up? Bad English and a github address makes me unhappy.
>>
>> I can imagine that you decided not to use kernel.org due to hera being
>> down, but this still makes me want to say "please more references".
>>
> shouldn't all pull request be digitally signed, by _default_ ?
>
nah... you can forget about the question, as it would just mean that
all the chain from the original submitter would need to be signed to
be trustable...

- A.

2011-08-31 21:42:36

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [GIT PULL] ext4 fixes for 3.1-rc5

On Wed, Aug 31, 2011 at 11:25:58AM -0700, Linus Torvalds wrote:
> On Wed, Aug 31, 2011 at 10:46 AM, Theodore Ts'o <[email protected]> wrote:
> >
> > Please pull from:
> >
> > ? ? ? ?git://github.com/tytso/ext4.git for_linus-20110831 # 8c0bec2151a
> >
> > to get the following bug fix. ?It address a lockdep warning which a lot
> > of people have been complaining about.
>
> So what's up? Bad English and a github address makes me unhappy.
>
> I can imagine that you decided not to use kernel.org due to hera being
> down, but this still makes me want to say "please more references".

Yes, I decided to use github because master.kernel.org is down.
for_linus-20110831 is a signed tag, which you can verify.

Sorry for the bad english, I was doing too many other things at the
same time when I was composing the pull request. The pull should
consist of a single commit to fix a Lockddep complain; see:

https://bugzilla.kernel.org/show_bug.cgi?id=41682

I just realized I forgot to include the BZ URL in the commit
description; sigh, sorry about that. Would you prefer that I ammend
the commit and send you a new pull request?

- Ted

2011-09-03 18:17:23

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [GIT PULL] ext4 fixes for 3.1-rc5

On Wed, Aug 31, 2011 at 05:42:33PM -0400, Ted Ts'o wrote:
>
> I just realized I forgot to include the BZ URL in the commit
> description; sigh, sorry about that. Would you prefer that I ammend
> the commit and send you a new pull request?

Hi Linus,

So I never got a reply about whether you wanted me to commend the
commit to include the Kernel Bugzilla. If you didn't pull from the
for_linus branch, please do so now to get the following commit. It is
also tagged with the signed tag for_linus-20110902, and has the commit
id dc993e2060f0f. If you have, no worries. The only difference was in
the commit description where I added the URL of the Kernel Bugzilla.

Thanks,

- Ted

Jiaying Zhang (1):
ext4: remove i_mutex lock in ext4_evict_inode to fix lockdep complaining

fs/ext4/ext4.h | 1 +
fs/ext4/inode.c | 3 ---
fs/ext4/page-io.c | 18 +++++++++++++++++-
3 files changed, 18 insertions(+), 4 deletions(-)

2011-09-03 19:21:15

by Linus Torvalds

[permalink] [raw]
Subject: Re: [GIT PULL] ext4 fixes for 3.1-rc5

On Sat, Sep 3, 2011 at 11:17 AM, Ted Ts'o <[email protected]> wrote:
>
> So I never got a reply about whether you wanted me to commend the
> commit to include the Kernel Bugzilla. ?If you didn't pull from the
> for_linus branch, please do so now to get the following commit.

I already pulled a few days ago, I just haven't pushed out since
kernel.org is still down, and I didn't think that any of the stuff I
have in my own tree is important enough that I'd need to publish it
anywhere else..


Linus