2013-12-19 06:41:04

by Yongqiang Yang

[permalink] [raw]
Subject: Re: [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size

can be reproduced by xfstests 62 with bigalloc and 128bit size inode.

Thanks,
Yongqiang.

On Thu, Dec 19, 2013 at 2:38 PM, Yongqiang Yang
<[email protected]> wrote:
> From: Yongqiang Yang <[email protected]>
>
> Signed-off-by: Yongqiang Yang <[email protected]>
> ---
> fs/ext4/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 9115f28..1869fcf 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -145,7 +145,7 @@ static int ext4_meta_trans_blocks(struct inode *inode, int lblocks,
> static int ext4_inode_is_fast_symlink(struct inode *inode)
> {
> int ea_blocks = EXT4_I(inode)->i_file_acl ?
> - (inode->i_sb->s_blocksize >> 9) : 0;
> + EXT4_CLUSTER_SIZE(inode->i_sb) >> 9 : 0;
>
> return (S_ISLNK(inode->i_mode) && inode->i_blocks - ea_blocks == 0);
> }
> --
> 1.8.5.2
>



--
Best Wishes
Yongqiang Yang


2013-12-20 04:22:52

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size

On Thu, Dec 19, 2013 at 02:40:42PM +0800, Yongqiang Yang wrote:
> can be reproduced by xfstests 62 with bigalloc and 128bit size inode.

Hi Yongqiang,

I can't find the original message you were replying. I can
reconstruct the 2/2 patch, but is there a 1/2 patch that you had meant
to send to the linux-ext4 list?

Many thanks,

- Ted

2013-12-20 04:59:09

by Yongqiang Yang

[permalink] [raw]
Subject: Re: [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size

On Fri, Dec 20, 2013 at 12:22 PM, Theodore Ts'o <[email protected]> wrote:
> On Thu, Dec 19, 2013 at 02:40:42PM +0800, Yongqiang Yang wrote:
>> can be reproduced by xfstests 62 with bigalloc and 128bit size inode.
>
> Hi Yongqiang,
>
> I can't find the original message you were replying. I can
> reconstruct the 2/2 patch, but is there a 1/2 patch that you had meant
> to send to the linux-ext4 list?
Interesting, I sent the patch to ext4 list and you. I will resend them.

Thanks,
Yongqiang.
>
> Many thanks,
>
> - Ted



--
Best Wishes
Yongqiang Yang

2013-12-20 05:01:33

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH 2/2] ext4: ext4_inode_is_fast_symlink should use cluster size

On Fri, Dec 20, 2013 at 12:58:47PM +0800, Yongqiang Yang wrote:
> > I can't find the original message you were replying. I can
> > reconstruct the 2/2 patch, but is there a 1/2 patch that you had meant
> > to send to the linux-ext4 list?
> Interesting, I sent the patch to ext4 list and you. I will resend them.

Thanks. I couldn't find the patches on either gmane[1] or patchwork[2].

[1] http://news.gmane.org/gmane.comp.file-systems.ext4
[2] http://patchwork.ozlabs.org/project/linux-ext4/list/

So I'm guessing it got lost before reaching vger.kernel.org.

regards,

- Ted