2009-07-02 12:49:24

by Kay Sievers

[permalink] [raw]
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

On Thu, Jul 2, 2009 at 03:15, Mike Frysinger<[email protected]> wrote:
> On Wednesday 01 July 2009 20:58:58 Theodore Tso wrote:
>> On Wed, Jul 01, 2009 at 06:35:06PM -0400, Mike Frysinger wrote:
>> > > In older udev releases, before we switched to automake, I had
>> > > something like this, which behaves a bit like the Linux kernel build,
>> > > and V=1 switches off the silent mode:
>> >
>> > why not just use automake-1.11's silent-rules option.  then you dont have
>> > to waste time reinventing the wheel.
>>
>> Because I consider automake the spawn of Satan?  :-)

Yeah, it is. It's strange what these tools produce. But it sees it's
slowly getting better over time not worse - so there is hope. Even the
recent libtool looks ok now. And I don't really miss the check for
FORTRAN, which seems to have disappeared here recently. :)

> i'll have you know Satan's wheel is awfully shiny ...

Heh, yeah. If you do not check-in the created stuff into git, and use:
git clean -d -X -f
autoreconf --install --symlink
to bootstrap a repo, stuff looks pretty good, I think. You just need
to be able to convince yourself not to look into the generated files.
:)

On the other hand the silent rules and "make distcheck" and all these
things which come along with automake are just great to have.

> Kay's rules look like they should be fairly straightforward to drop into
> e2fsprogs.  personally i'd use:
> E = @:
> when V=1, but this is probably just splitting hairs

Ah nice, looks good to me, if that works.

Thanks,
Kay


2009-07-02 14:25:28

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

On Thu, Jul 02, 2009 at 02:49:24PM +0200, Kay Sievers wrote:
> > Kay's rules look like they should be fairly straightforward to drop into
> > e2fsprogs. ?personally i'd use:
> > E = @:
> > when V=1, but this is probably just splitting hairs
>
> Ah nice, looks good to me, if that works.

Take a look at what I've checked into e2fsprogs' maint branch; it was
largely based on what you suggested.

If someone can point me at an autoconf test that determines whether or
not we're using gmake, I could even set up something which sucks in a
Makefile fragment that enhances what we can do for developers who are
using GNU make. (i.e., if you're using GNU make, "make V=1" will
DTRT, but if you're using a Solaris or BSD make, you'll have to settle
for "configure --enable-verbose-makecmds")

- Ted

2009-07-02 14:48:26

by Kay Sievers

[permalink] [raw]
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

On Thu, Jul 2, 2009 at 16:25, Theodore Tso<[email protected]> wrote:
> On Thu, Jul 02, 2009 at 02:49:24PM +0200, Kay Sievers wrote:
>> > Kay's rules look like they should be fairly straightforward to drop into
>> > e2fsprogs.  personally i'd use:
>> > E = @:
>> > when V=1, but this is probably just splitting hairs
>>
>> Ah nice, looks good to me, if that works.
>
> Take a look at what I've checked into e2fsprogs' maint branch; it was
> largely based on what you suggested.
>
> If someone can point me at an autoconf test that determines whether or
> not we're using gmake, I could even set up something which sucks in a
> Makefile fragment that enhances what we can do for developers who are
> using GNU make.  (i.e., if you're using GNU make, "make V=1" will
> DTRT, but if you're using a Solaris or BSD make, you'll have to settle
> for "configure --enable-verbose-makecmds")

I tried, and it works fine for me with the --enable-verbose-makecmds.

Thanks a lot,
Kay

2009-07-02 15:52:03

by Mike Frysinger

[permalink] [raw]
Subject: Re: [PATCH] configure.in: add --disable-libuuid option (Was: libuuid (Re: blkid: util-linux-ng vs. e2fsprogs))

On Thursday 02 July 2009 10:25:15 Theodore Tso wrote:
> On Thu, Jul 02, 2009 at 02:49:24PM +0200, Kay Sievers wrote:
> > > Kay's rules look like they should be fairly straightforward to drop
> > > into e2fsprogs. personally i'd use:
> > > E = @:
> > > when V=1, but this is probably just splitting hairs
> >
> > Ah nice, looks good to me, if that works.
>
> Take a look at what I've checked into e2fsprogs' maint branch; it was
> largely based on what you suggested.
>
> If someone can point me at an autoconf test that determines whether or
> not we're using gmake, I could even set up something which sucks in a
> Makefile fragment that enhances what we can do for developers who are
> using GNU make. (i.e., if you're using GNU make, "make V=1" will
> DTRT, but if you're using a Solaris or BSD make, you'll have to settle
> for "configure --enable-verbose-makecmds")

two methods:
- http://autoconf-archive.cryp.to/check_gnu_make.html
- a local "GNUmakefile" will be processed by GNU make only, and be done
before the normal Makefile
-mike


Attachments:
(No filename) (1.02 kB)
signature.asc (836.00 B)
This is a digitally signed message part.
Download all attachments