2020-05-22 15:10:35

by Jonny Grant

[permalink] [raw]
Subject: [PATCH] ext4: add comment for ext4_dir_entry_2 file_type member

From 4e9d768a0adb60698ba13e7b7522c15a4548332a Mon Sep 17 00:00:00 2001
From: Jonathan Grant <[email protected]>
Date: Fri, 22 May 2020 16:07:58 +0100
Subject: [PATCH] add comment for ext4_dir_entry_2 file_type member

Signed-off-by: Jonathan Grant <[email protected]>
---
fs/ext4/ext4.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index ad2dbf6e4924..7a042896bab7 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2050,7 +2050,7 @@ struct ext4_dir_entry_2 {
__le32 inode; /* Inode number */
__le16 rec_len; /* Directory entry length */
__u8 name_len; /* Name length */
- __u8 file_type;
+ __u8 file_type; /* See file type macros EXT4_FT_* below */
char name[EXT4_NAME_LEN]; /* File name */
};

--
2.17.1


2020-05-23 05:13:25

by Andreas Dilger

[permalink] [raw]
Subject: Re: [PATCH] ext4: add comment for ext4_dir_entry_2 file_type member

On May 22, 2020, at 9:09 AM, Jonny Grant <[email protected]> wrote:
>
> From 4e9d768a0adb60698ba13e7b7522c15a4548332a Mon Sep 17 00:00:00 2001
> From: Jonathan Grant <[email protected]>
> Date: Fri, 22 May 2020 16:07:58 +0100
> Subject: [PATCH] add comment for ext4_dir_entry_2 file_type member
>
> Signed-off-by: Jonathan Grant <[email protected]>

Reviewed-by: Andreas Dilger <[email protected]>

> ---
> fs/ext4/ext4.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index ad2dbf6e4924..7a042896bab7 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2050,7 +2050,7 @@ struct ext4_dir_entry_2 {
> __le32 inode; /* Inode number */
> __le16 rec_len; /* Directory entry length */
> __u8 name_len; /* Name length */
> - __u8 file_type;
> + __u8 file_type; /* See file type macros EXT4_FT_* below */
> char name[EXT4_NAME_LEN]; /* File name */
> };
>
> --
> 2.17.1
>


Cheers, Andreas





Attachments:
signature.asc (890.00 B)
Message signed with OpenPGP

2020-05-29 03:11:12

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] ext4: add comment for ext4_dir_entry_2 file_type member

On Fri, May 22, 2020 at 11:12:41PM -0600, Andreas Dilger wrote:
> On May 22, 2020, at 9:09 AM, Jonny Grant <[email protected]> wrote:
> >
> > From 4e9d768a0adb60698ba13e7b7522c15a4548332a Mon Sep 17 00:00:00 2001
> > From: Jonathan Grant <[email protected]>
> > Date: Fri, 22 May 2020 16:07:58 +0100
> > Subject: [PATCH] add comment for ext4_dir_entry_2 file_type member
> >
> > Signed-off-by: Jonathan Grant <[email protected]>
>
> Reviewed-by: Andreas Dilger <[email protected]>

Thanks, applied.

- Ted