2010-03-16 10:54:44

by Steven Liu

[permalink] [raw]
Subject: [PATCH 1/1]ext4: cleanup a warning

Hi Ted,

I have get a warning, too,


fs/ext4/move_extent.c:478: warning: start_ext.ee_block may be used
uninitialized in this function

my compiler version:

gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7)
Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


I think i'm not the first get this warning,then i make a patch for
this warning, can you fix it in?

Signed-off-by: Qi Liu ([email protected])

diff --git a/ext4/fs/ext4/move_extent.c.orig b/ext4/fs/ext4/move_extent.c
index aa5fe28..b399358 100644
--- a/ext4/fs/ext4/move_extent.c.orig
+++ b/ext4/fs/ext4/move_extent.c
@@ -481,6 +481,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode,
int depth = ext_depth(orig_inode);
int ret;

+ start_ext.ee_block = end_ext.ee_block = 0;
o_start = o_end = oext = orig_path[depth].p_ext;
oext_alen = ext4_ext_get_actual_len(oext);
start_ext.ee_len = end_ext.ee_len = 0;




Qi Liu