2023-05-30 07:04:49

by Hannes Reinecke

[permalink] [raw]
Subject: Re: [PATCH 08/11] iomap: use kiocb_write_and_wait and kiocb_invalidate_pages

On 5/24/23 08:38, Christoph Hellwig wrote:
> Use the common helpers for direct I/O page invalidation instead of
> open coding the logic. This leads to a slight reordering of checks
> in __iomap_dio_rw to keep the logic straight.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> Reviewed-by: Damien Le Moal <[email protected]>
> Reviewed-by: Darrick J. Wong <[email protected]>
> ---
> fs/iomap/direct-io.c | 55 ++++++++++++++++----------------------------
> 1 file changed, 20 insertions(+), 35 deletions(-)
>
Reviewed-by: Hannes Reinecke <[email protected]>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
[email protected] +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman